Modification to parserPopUp and PGbasic macros for Moodle opaque

[JonathanDesaulniers]

Modification to PGbasicmacros so that radio button and checkbox can be use in Moodle with opaque server. Note that the checkbox still has issues (only the last checked box is saved).

Modification to parserPopUp so that the PopUp command can be use in Moodle with opaque server.

[drgrice1]

I don't think that I can approve of this pull request. Adding this prefix to the pg code does not seem right.

There is already a QUIZ_PREFIX that you could use for this purpose. Admittedly that is not always necessarily a true prefix (e.g., MultiAnswers can add a prefix in front of that), but this will work for most answers.

Furthermore, you have not provided any real explanation of the changes made. How exactly does it work? How can this be tested?

[JonathanDesaulniers]

Hi, Your suggestion would mean to change many many problème to add quiz_prefix….this would take an enormous amount of time instead of using them right away!!!!! The change made only push a Moodle question prefix (most of the time ine the form of q##### where ##### is an identification number for the question in a Moodle quiz) on the input or select element of the html generated for Moodle. This was already added for pop_up_list in the PGbasicmacro….i just extended the use for radio button and checkbox. If your not in Moodle, this won’t do anything cuz no prefix will be added. Since we are about to extend the use of opaque_server to many institution in Quebec, we want an effective solution and this one seem to be the best with no consequence for usage of those macro outside Moodle. This can be tested if you install the question opaque_server! Else you wont notice any change. ***@***.*** Jonathan Desaulniers Spécialiste en développement pédagonumérique du RÉCIT Service national dans le domaine de la Mathématique, de la Science et Technologie 514-668-9656 recitmst.qc.ca<https://recitmst.qc.ca/> ***@***.***<https://www.linkedin.com/in/jonathan-desaulniers-587a03bb/> ***@***.*** <https://www.facebook.com/jonathan.desaulniers.5> Connaissez-vous nos formations? Visitez campus.recit.qc.ca<https://campus.recit.qc.ca/> De : Glenn Rice ***@***.***> Envoyé : 10 février 2022 09:55 À : openwebwork/pg ***@***.***> Cc : Jonathan Desaulniers ***@***.***>; Author ***@***.***> Objet : Re: [openwebwork/pg] Modification to parserPopUp and PGbasic macros for Moodle opaque (PR #647) @drgrice1 commented on this pull request. I don't think that I can approve of this pull request. Adding this prefix to the pg code does not seem right. There is already a QUIZ_PREFIX that you could use for this purpose. Admittedly that is not always necessarily a true prefix (e.g., MultiAnswers can add a prefix in front of that), but this will work for most answers. Furthermore, you have not provided any real explanation of the changes made. How exactly does it work? How can this be tested? — Reply to this email directly, view it on GitHub<#647 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AUH7CLCMTAYM3UF3CIYVBYDU2PGVRANCNFSM5NKF2QUQ>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>

[drgrice1]

I see that @mgage added the opaque prefix in some cases already.

This needs to be thought out better. Adding prefixes in PG is not the correct way to do this. You would not need to edit problems to use the QUIZ_PREFIX. You would need to set it up so that the prefix is set by the rendering mechanism.

[JonathanDesaulniers]

I understand, but like I said the Moodle prefix was previously added on macros like PGbasicmacro for the pop_up_list section (I don’t know how many there is out there or when were they added??) I’m gonna try pushing it within the opaque_server when it pass the html to Moodle and check if the Prefix was previously added so it doesn’t double up. I get that it would be a more durable solution!!! We can withdraw that pull request!!! ***@***.*** Jonathan Desaulniers Spécialiste en développement pédagonumérique du RÉCIT Service national dans le domaine de la Mathématique, de la Science et Technologie 514-668-9656 recitmst.qc.ca<https://recitmst.qc.ca/> ***@***.***<https://www.linkedin.com/in/jonathan-desaulniers-587a03bb/> ***@***.*** <https://www.facebook.com/jonathan.desaulniers.5> Connaissez-vous nos formations? Visitez campus.recit.qc.ca<https://campus.recit.qc.ca/> De : Glenn Rice ***@***.***> Envoyé : 10 février 2022 10:44 À : openwebwork/pg ***@***.***> Cc : Jonathan Desaulniers ***@***.***>; Author ***@***.***> Objet : Re: [openwebwork/pg] Modification to parserPopUp and PGbasic macros for Moodle opaque (PR #647) I see that @mgage<https://github.com/mgage> added the opaque prefix in some cases already. This needs to be thought out better. Adding prefixes in PG is not the correct way to do this. You would not need to edit problems to use the QUIZ_PREFIX. You would need to set it up so that the prefix is set by the rendering mechanism. — Reply to this email directly, view it on GitHub<#647 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AUH7CLAU5ALELQSV62IIHKLU2PMLDANCNFSM5NKF2QUQ>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>

[drgrice1]

There is no need to withdraw the pull request. But more consideration is needed. There is surely a better way to implement this than adding this prefix all over in the PG code.