Full support for extended base URLs #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WeBWorK::PG module is now part of PG, and PG has its own environment
so the webwork2 WeBWorK::PG module (and its derivatives) have been
removed.
The WeBWorK::Constants, WeBWorK::Debug, and WeBWork::CourseEnvironment
modules and the webwork2 conf files are no longer needed and so are
removed. The renderer uses the WeBWorK::PG::Environment module which is
part of PG. Note that this adds one minor installation step for the
renderer. The file conf/pg_config.yml must be copied to lib/PG/conf.
Usually that file will work as is, but in some cases administrators may
want to make changes to it. For example, the externalPrograms are the
standard linux executables and in the standard locations. On some
systems those may need to be changed.
Most of the WeBWorK::Utils module has been removed. All that is left is
the two methods that the renderer uses.
In addition the renderer lib directory has been flattened.
lib/WeBWorK/lib/WeBWorK is now just lib/WeBWorK. With this (among other
things) the WEBWORK_ROOT environment variable is not needed. Note that
$WeBWorK::Constants::PG_DIRECTORY is not available. $ENV{PG_ROOT} is
used instead in the renderer code.
Note that the unnecessary encoding and decoding of perl warnings has
been removed.
Also note that the references to drdrew42 have been changed to
openwebwork.
Update the renderer for the restructuring of PG in openwebwork/pg#709
escape quote after encoding json
|
This also includes changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building off of #14, this PR ensures that the renderer fully supports extended baseURLs for implementation alongside multiple services on the same server. This includes development mode.
Configuration settings for
baseURLandformURLare now sanitized -- and warnings provided for mis-configuration. I think I have handled (perhaps redundantly) the various ways that these might be specified. For example, the PG environment variables forhtmlURLandtempURLare specified, thus overriding the automatic generation from Environment.pm. This is done for consistency with other relative URLs in the rendered HTML.The two interfaces: two-pane problem editor & opl filebrowser / tagging interface, both now work with extended baseURLs as well.