Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production #1140

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Production #1140

wants to merge 2 commits into from

Conversation

Alex-Jordan
Copy link
Contributor

This is several years of accumulated changes to PCC files in the OPL. Every change here is either in OpenProblemLibrary/PCC, OpenProblemLibrary/macros/PCC, or Contrib/PCC.

@drdrew42
Copy link
Member

😱
Screenshot 2024-04-10 at 12 45 35 PM

Is this the GitHub equivalent of a trust-fall? 😆

@Alex-Jordan
Copy link
Contributor Author

Hmm... so, is there a git way to confirm that the changes here only affect PCC files?

Let me look into this on my end. I'm surprised we have that many files, but maybe it's around 2500 and then doubled for the OPL and Contrib. Maybe it will help if I split into to PRs based on that. Or chunk it out by some folders versus other folders.

@drdrew42
Copy link
Member

drdrew42 commented Apr 10, 2024

I just want to confirm that this is indeed limited to PCC files -- 5k is pretty massive. If it isn't too much work, splitting this into PRs at least for OPL/PCC vs Contrib/PCC sounds like a good start. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants