-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for user_sets and user_set versioning #113
Open
pstaabp
wants to merge
14
commits into
openwebwork:main
Choose a base branch
from
pstaabp:add-mojo-user-set-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstaabp
force-pushed
the
add-mojo-user-set-test
branch
3 times, most recently
from
August 25, 2022 09:32
6948b58
to
44c53f5
Compare
WIP: cleanup the tests WIP: deleting from db--update store tests
WIP: cleanup the tests WIP: deleting from db--update store tests
WIP: add user-set tests to mojolicious routes WIP: add user-set tests to mojolicious routes WIP: updated user_sets tests to check for permissions FIX: update the way the set_version param is fetched to avoid error. WIP: new set_version mojolicious test. WIP: new set_version mojolicious test. WIP: deleting from db--update store tests WIP: cleanup the tests WIP: deleting from db--update store tests WIP: send message from mojolicious layer and more cleanup. FIX: update the pinia store tests. WIP: add user-set tests to mojolicious
pstaabp
force-pushed
the
add-mojo-user-set-test
branch
from
August 26, 2022 17:26
44c53f5
to
90924be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests (both perl and jest) for user_sets and set versioning. A few changes have been made as well:
course_user_id
was used,user_id
is used instead for easier handling of permissions mostly related to those with self_access.set_version => 0
This depends on #112