Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Simplify implementation of userCollection MongoDB adapter #18

Merged
merged 6 commits into from
Mar 28, 2022
Merged

fix: Simplify implementation of userCollection MongoDB adapter #18

merged 6 commits into from
Mar 28, 2022

Conversation

adrienjoly
Copy link
Member

@adrienjoly adrienjoly commented Mar 25, 2022 •
edited
Loading

Cf #7 (comment) and #17 (comment).

Comment tester

docker-compose up -d mongo

npm run test:approval

source ./env-vars-testing-local.sh
npm run test:integration:post

@adrienjoly adrienjoly self-assigned this Mar 25, 2022
@adrienjoly adrienjoly marked this pull request as ready for review March 25, 2022 09:32
@adrienjoly adrienjoly marked this pull request as draft March 25, 2022 09:33
@adrienjoly adrienjoly changed the title goal: Simplify userCollection.insertPlaylist() implementation fix: Simplify userCollection.insertPlaylist() implementation Mar 25, 2022
@adrienjoly
Copy link
Member Author

adrienjoly commented Mar 25, 2022 •
edited
Loading

At this stage:

  • npm run test:approval passes
  • npm run test:integration:post passes

Note: if we clear the implementation of userCollection.insertPlaylist(), one Cypress test fails: "should allow user to re-add a track into a playlist", as it should 👌

@adrienjoly adrienjoly changed the title fix: Simplify userCollection.insertPlaylist() implementation fix: Simplify implementation of userCollection MongoDB adapter Mar 25, 2022
@adrienjoly adrienjoly requested a review from julien-topcu March 25, 2022 10:22
@adrienjoly adrienjoly mentioned this pull request Mar 25, 2022
Open
1 task
@adrienjoly adrienjoly marked this pull request as ready for review March 28, 2022 07:17
@adrienjoly adrienjoly merged commit bfe0242 into main Mar 28, 2022
@adrienjoly adrienjoly deleted the fix/simplify-insertplaylist-implementation branch March 28, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-topcu julien-topcu julien-topcu approved these changes

@JKratus JKratus JKratus approved these changes

Assignees

@adrienjoly adrienjoly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrienjoly @JKratus @julien-topcu