[fix] Fixed bugs in auto-install script #299 #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
pandafy
force-pushed
the
issues/299-autoinstall
branch
15 times, most recently
from
e81d67b to
df05446
Compare
nemesifier
reviewed
Jul 19, 2024
images/openwisp_websocket/Dockerfile
Outdated
| @@ -1,5 +1,5 @@ | |||
| # hadolint ignore=DL3007 | |||
| FROM openwisp/openwisp-base:latest | |||
| FROM openwisp/openwisp-base:stable | |||
There was a problem hiding this comment.
now that I see this here, it's misleading here, latest was better.
There was a problem hiding this comment.
I think, we should use "edge"/"dev" everywhere in the code with an option to override the tag when required (while publishing). If someone is trying to build the images from source, they most likely would want the versioh which is present in the code.
nemesifier
requested changes
Jul 20, 2024
pandafy
force-pushed
the
issues/299-autoinstall
branch
2 times, most recently
from
e9a5156 to
3f45ce4
Compare
nemesifier
requested changes
Jul 22, 2024
nemesifier
approved these changes
Jul 22, 2024
pandafy
force-pushed
the
issues/299-autoinstall
branch
from
7fc0ea7 to
0b95cb9
Compare
nemesifier
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated CI to use auto-install script for spawning containers.
Closes #299