[change] OpenWrt: updated WPA enterprise settings #291 #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandafy
force-pushed
the
issues/291-wpa-enterprise
branch
from
c45cf89 to
0c83f93
Compare
- Generate "auth_sever", "auth_port" and "auth_secret" options from "server", "port" and "key" properties - Set "acct_secret" to the value of "key" if it is not configured in NetJSON - Add new options: "acct_inverval", "dae_client", "dae_port", "dae_secret" Closes #291
pandafy
force-pushed
the
issues/291-wpa-enterprise
branch
from
0c83f93 to
91d8e8d
Compare
nemesifier
reviewed
Feb 10, 2024
…t option in OpenWrt
nemesifier
requested changes
Mar 14, 2024
tests/openwrt/test_encryption.py
Outdated
| @@ -368,6 +383,9 @@ def test_render_wpa3_enterprise(self): | |||
|
|
|||
| def test_parse_wpa3_enterprise(self): | |||
| o = OpenWrt(native=self._wpa3_enterprise_ap_uci) | |||
| from pprint import pprint | |||
|
|
|||
| pprint(dict(o.config)) | |||
| for option in ['server', 'port']: | ||
| if f'auth_{option}' in settings: | ||
| settings[option] = settings.pop(f'auth_{option}') | ||
| if settings.get('acct_port'): |
There was a problem hiding this comment.
why not if 'acct_port' in settings? Why using get here? Is it on purpose?
| uci['auth_secret'] = encryption['key'] | ||
| if not encryption.get('acct_secret'): | ||
| uci['acct_secret'] = encryption['key'] | ||
| if encryption.get('acct_server_port'): |
| if option in encryption: | ||
| uci[f'auth_{option}'] = encryption[option] | ||
| uci['auth_secret'] = encryption['key'] | ||
| if not encryption.get('acct_secret'): |
nemesifier
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #291