Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MOBILE-7084: Introduce iOS integration docs for rendering module #26

Open
wants to merge 29 commits into
base: feature-rendering-module
Choose a base branch
from
Open

MOBILE-7084: Introduce iOS integration docs for rendering module #26

wants to merge 29 commits into from

Conversation

KostiantynTselykh
Copy link

@KostiantynTselykh KostiantynTselykh commented Jun 2, 2021 •
edited
Loading

doc:

  • Applied changes to integration-prebid for gam
  • Applied changes to integration-prebid for mopub
  • Applied changes to integration-prebid for ppm
  • Applied changes in info folder
  • Removed unneeded docs
  • Removed delegate section
  • Changed images
  • Added gam native integration info

NOTE: There are 2 TODO code sections (can be found by TODO keyword):

  1. For native ad integration with PPM (using NativeUtils.findNativeAd). I didn't find an example when was searching for NativeUtils keyword in xcode project.
  2. MoPub native ad integration requires description and integration example on how it is implemented on iOS (because on Android we use only mediation adapters for native ads).
    @VadimKhohlovOpenX @YuriyVelichkoOpenX Feel free to add those examples by yourself or by providing me a hint on where I can find it.

Please look closely if there are some redundant prefixes.

xvadim12 and others added 22 commits April 5, 2021 16:36
@xvadim12
- update cocoapods version in Podfile.lock
9dda581
@VadimKhohlovOpenX @KostiantynTselykh @xvadim12
MOBILE-7000: [iOS] Introduce the Rendering module in the Prebid repo (#1
529e571 
)

* chore(fastlane):
fix iOS version for simulator
fix simulators' names
fix build script
introduce the rendering module

* chore(build): update build scripts

* chore(InternalApp): disable GAM Ad validators

* chore(migration): reorder file structure

* chore(migration): tune simulator name

* chore(migration): tune simulator name for builds and fastlane

* chore(SDK tests): remove unused vars

* chore(build): fix working directory

* chore(build): set build-machine label to android-tests

* Revert "chore(build): set build-machine label to android-tests"

This reverts commit 5fef3ed.

Co-authored-by: KostiantynTselykh <[email protected]>
Co-authored-by: xvadim12 <[email protected]>
@VadimKhohlovOpenX
MOBILE-7003: [iOS] Rename products (#2)
111435a 
* chore(migration): rename bundle id for the internal app

* chore(migration): rename internal test app

* chore(migration): rename GAM Event Handlers

* chore(migration): rename MoPub Adapters

* chore(migration): rename EH/Adapter modules

* chore(migration): rename rendering core SDK

* chore(migration): cleanup code

* chore(migration): fix build scripts

* chore(migration): fix tests for GAM Event Handlers
@VadimKhohlovOpenX
MOBILE-7011: [iOS] Rename classes methods and class prefixes (#3)
ff242a4 
* chore(migration): replace substring 'apollo' by 'prebid'

* chore(migration): replace substring 'openx' by 'prebid'

* chore(migration): rename unit-tests subproject

* chore(migration): rename internal directories

* chore(migration): rename prefixes OXM/OXA to PBM in the core module

* chore(migration): rename prefixes OXM/OXA to PBM in the MoPub adapters

* chore(migration): rename prefixes OXM/OXA to PBM in the GAM Event handlers

* chore(migration): rename prefixes OXM/OXA to PBM in the Internal App

* chore(migration): rename prefixes oxm/oxa

* chore(migration): rename resources

* chore(migration): add missed files to the reposetory

* chore(migration): merge PBMError and OXMError to one class

* chore(migration): fix the name of scheme for Rendering SDK testing

* chore(migration): rename OXMAdFormat

* chore(migration): clean up code

* chore(migration): fix names in the internal app
@VadimKhohlovOpenX
MOBILE-7012: [iOS] Introduce ability to set custom host for PBS (#4)
8385669 
* chore(migration): implement ability to set custom host for PBS

* chore(test): tune GAM tests loadTimeout value

* fix(tests): force switching mock/prebid server for UI-tests
@VadimKhohlovOpenX
MOBILE-7023: [iOS][Swift] Make OXABidRequester as a Project class
0ad2f51 
fix(SDK):  make PBMBidRequester as a project class
@VadimKhohlovOpenX
MOBILE-7047: [iOS] Replace OM SDK with prebid's version (#5)
2f9879e 
* refactor(SDK): replace OMSDK by the prebid's version

* chore(tests): increase load timeout for DFP tests

* refactor(SDK): update unit-tests after replacing OMSDK
@VadimKhohlovOpenX
MOBILE-7024: [iOS][Swift] Migrate Media View and Media Data (#7)
251cda5 
* refactor(SDK): rewrite PBMMediaData on Swift

* refactor(SDK): rewrite PBMMediaView on Swift

* chore(build scripts): fix iOS version

* fix(tests): fix a test

* refactor(SDK): cleanup code
@YuriyVelichkoOpenX @YuriyVelichkoPI
Mobile 7054 update gam in prebid gam event handlers (#9)
e42d61f 
* chore (GAMEventHandler): update GAM to the latest version 8.4.0

* chore (GAM): fixes for application

* chore (GAM):
- remove GoogleMobileAdsMediationTestSuite. Reasons: it doesn't support GMA SDK v8, we do not use GAM mediation anymore.
- update platform version in podfile to iOS 10. GMA SDK requires Target iOS 10.0 or higher

* chore (GAM): update platform to iOS 10. GMA SDK suports Target iOS 10.0 or higher

* chore (Migration): Swift classes for GAM Utils

* chore (Migration to Swift): remove OBJ-C utils. Fix unit tests project

* chore (Migration to Swift): ix build of internal test app

* chore (Migration to Swift): fix some par of unit tests TODO: change behaviour for interstitial ads

* chore (Migrate to swift): replace Reward classes

* chore (Migration to Swift): introduce swift version of Interstitial event handler

* chore  (Migration to Swift): replace wrapper for Interstitial ad

* chore (Migration to Swift): small fixes for Interstitial

* chore (Migration to Swift): update and fix unit tests

* chore (Migration to Swift): corrections for rewarded video

* chore (Migration to Swift): prepare GAMBannerEventHandler

* chore (Migration to Swift): prepare banner event handler

* chore (Migration to Swift): remove ObjC Banner handler

* chore (Migration to Swift): remove boxed banner view

* chore (Migration to Swift): rewrite boxed request

* chore (Migration to Swift): migrate  boxed native ad

* chore (Migration to Swift): migrate boxed class for native custom ad

* chore (Migration to Swift): remove invocation helpers

* chore (Migration to Swift): changes in the project file

* chore (Migration to Swift): remove OBJC constants

* chore (migration to Swift): replace Error

* chore  (Migration to Swift): remove modulemap

* chore (Migration to Swift): fix Unit Tests for GAM Event Handler

* chore (Migrate to Swift): swiftify code

* chore (Migration to Swift): swiftify code

* chore (Migration to Swift): update commit settings

* chore (Migration to Swift): fix build after rebase

* fix build

* fix: fix rendering of Native Ads. Add unit tests

* fix: corrections for PR

Co-authored-by: Yuriy Velichko <[email protected]>
@YuriyVelichkoOpenX
Mobile 6968 update mo pub in prebid mo pub adapters to the latest ver…
a3fd2af 
…sion (#10)

* feat (MoPub Event Handler): update MoPub version in the  Pod file

* feat (MoPub Adapter): pod update

* feat  (MoPub Adapters): update MoPub to the latest version

* fix (Application): fix warnings

* feat (MoPub Adapter): add tests to the demo App
@VadimKhohlovOpenX
MOBILE-7016: [iOS][Swift] Migrate Native Assets (#11)
0ad4570 
* refactor(SDK): rewrite PBMNativeAssetTitle on Swift

* refactor(SDK): rewrite PBMNativeAssetData on Swift

* refactor(SDK): rewrite PBMNativeAssetImage on Swift

* refactor(SDK): rewrite PBMNativeAssetVideo on Swift

* refactor(SDK): rewrite PBMNativeAsset on Swift

* refactor(SDK): cleanup NativeAsset.swift

* chore: resolve conflicts after merge

* refactor(SDK): improve NativeAssets' code
@YuriyVelichkoOpenX
Mobile 7018 Migrate MoPub API classes (#13)
1574b2f 
* refactor (MoPub Adapters): rewrite PrebidMoPubNativeCustomEvent to Swift

* feat (Migration  to Swift): migrate PrebidMoPubNativeAdRenderer

* feat  (Migration to Swift): migrate PrebidMoPubNativeCustomEvent

* feat (Migration to Swift): migrate  PrebidMoPubAdaptersUtils

* refactor (Migration to Swift): migrate PrebidMoPubBannerAdapter to Swift

* refactor (Migration to Swift): migrate PrebidMoPubInterstitialAdapter

* refactor (Migration to Swift): replace VideoInterstitial and Rewarded Controllers

* refactor (Migration to Swift): migrate Configuration class and remove all other unneeded objc classes

* fix: fix UI test

* refactor (Migration to Swift): small corrections

* fix: fix ui tests

* fix: fix in the Demo App for native Styles

* fix: fix GAM interstitial flow

* refactor (Migration to Swift): prepare class MoPubInterstitialAdUnit

* refactoring (Migration to Swift): remove ObjC class

* refactoring (Migration to Swift): fix unit test target

* refactor (Migration to Swift): migrate Rewarded ad unit

* refactor (Migration to Swift): fix build of unit tests

* refactor (Migration to Swift): prepare the swift version of PBMMoPubBaseInterstitialAdUnit

* refactor (Migration to Swift): remove ObjC class PBMMoPubBaseInterstitialAdUnit

* fix: fix build of Unit Tests

* refactor (Migration to Swift): prepare MoPubNativeAdUnit

* refactor (Migration to Swift): remove MoPubNativeAdUnit

* refactor (Migration to Swift): prepare MoPubBannerAdUnit

* refactor (Migration to Swift): remove ObjC class for bannner

* refactor (Migration to Swift): prepare  MoPubUtils

* refactor (Migration to Swift): remove ObjC MoPubUtils

* fix: fix the preparation of MoPub ad object

* refactor (Migration to Swift): restore build of unit tests

* refactor (Migration to Swift): fix unit tests

* fix: fix MoPub rewarded ads

* fix: fixes after rebase

* fix: fix build of Unit  Tests
@VadimKhohlovOpenX
MOBILE-7017: [iOS][Swift] Migrate Native Ad classes (#15)
4e2e047 
* refactor(SDK): rewrite PBMNativeAdTitle on Swift

* refactor(SDK): resolve issues after merge

* refactor(SDK): rewrite PBMNativeAdImage on Swift

* refactor(SDK): rewrite PBMNativeAdData on Swift

* refactor(SDK): rewrite PBMNativeAdVideo on Swift

* refactor(SDK): rewrite PBMNativeAdEventTracker on Swift

* refactor(SDK): rewrite PBMNativeAdDetectionListener on Swif

* refactor(SDK): rewrite PBMNativeAdAsset on Swift

* refactor(SDK): rewrite PBMNativeAdAssetBoxingError on Swift

* refactor(SDK): rewrite PBMNativeAdConfiguration on Swift

* refactor(SDK): rewrite PBMNativeAdUnit on Swift

* refactor(SDK): rewrite PBMNativeAd on Swift

* chore: fix lint warnings

* refactor(SDK): fix tests after renaming PBMNativeAd

* chore(SDK): fix errors after syncing

* refactor(SDK): fix request generation for NativeAd

* refactor(SDK): fix request generation for NativeAd

* refactor(SDK): fix warnings of NativeAd rewriting

* chore: add a comment about strange code
@VadimKhohlovOpenX
MOBILE-7022/32: [iOS][Swift] Migrate OXARewardedAdUnit/OXAInterstitia…
5c445ba 
…lAdUnit (#16)

* refactor(SDK): rewrite PBMRewardedAdUnit

* refactor(SDK): rewrite PBMInterstitialAdUnit

* refactor(SDK): fix errors after syncing

* refactor(SDK): fix review warnings
@YuriyVelichkoOpenX
Mobile 7025 migrate oxa banner view (#17)
997af28 
* Need to  squash commits first to avoid ugly merge conflicts

fix: fix test
refactor (Migration to Swift): add accessibility identifier to the new Banner view, fix tests
refactor (Migration to Swift): format code, fix unit test
refactor (Migration to Swift): fix demo app
refactor (Migration to Swift): fix unit test target
refactor (Migration to Swift): remove obj classes for BannerView and BannerViewDelegate
refactor (Migration to Swift): confirm BannerView to new BannerViewDelegate protocol
refactor (Migration to Swift): migrate other methods
refactor (Migration to Swift): prepare the banner  view delegate
refactor (Migration to Swift): rewrite code for banner view - final part
refactor (Migration to Swift): add methods for context data
refactor (Migration to Swift): migration of Banner view  (in progress)
refactor (Migration to Swift): migrate Banner View, step 1

* fix: fix build after rebase

* fix: corrections for failed tests

* fix: fix for native style

* fix: fix runtime warning for accessing the UIView in the main thread

* fix: add @objc for public methods and properties
@VadimKhohlovOpenX
Mobile 7031 migrate oxa interstitial controller (#18)
95f1693 
* refactor(SDK): rewrite PBMInterstitialController

* refactor(SDK): fix errors after syncing

* refactor(SDK): rename PBMInterstitialController -> InterstitialController

* chore(SDK): increase timeouts for tests

* chore(SDK): fix errors after syncing
@YuriyVelichkoOpenX
Mobile 7020 migrate ad unit configuration (#19)
dea2e6d 
* refactor (Migration to Swift): prepare AdUnitConfig object

* refactor (Migration to Swift): remove ObjC adunit config

* fix: fix test

* refactoring (Migration to Swift): use CGSize instead of NSValue in MoPub and GAM handlers

* fix: fix for unit  tests

* refactor (Migration to  Swift): cleanup migration headers

* fix: fix build
@VadimKhohlovOpenX
MOBILE-7030: [iOS][Swift] Migrate OXALocalResponseInfoCache (#20)
34e3652 
* rewrite PBMLocalResponseInfoCache on Swift
@VadimKhohlovOpenX
Mobile 7028: [iOS][Swift] Migrate Bid Request and Response structures (…
c7cf784 
…#22)

* refactor(SDK): rewrite PBMBidResponse on swift

* refactor(SDK): rewrite PBMDemandResponseInfo on swift

* efactor(SDK): rewrite PBMBid on swift

* refactor(SDK): fix tests after renaming

* refactor(SDK): rename PBMBidResponse -> BidResponse

* refactor(SDK): fix errors after syncing

* chore(SDK): fix interoperability between objc & Swift
@YuriyVelichkoOpenX
Mobile 7019 migrate sdk configuration (#21)
bc3dd22 
* refactor (Migration to Swift): prepare the class PrebidMobileRendering

* refactor (Migration to Swift): fix build of Unit Tests

* refactor (Migration to Swift): fixes for unit tests

* refactor (Migration to Swift): introduce the Swift class for Targeting

* refactor (Migration to Swift): remove ObjC Targeting class

* fix: fix unit tests

* fix: fix unit tests

* fix: fix after  rebase

* fix: fix after rebase
@YuriyVelichkoOpenX
Fix refresh banners in background and in invisible state (#23)
28db81b
@KostiantynTselykh
doc:
0456694 
- Applied changes to integration-prebid for gam
- Applied changes to integration-prebid for mopub
- Applied changes to integration-prebid for ppm
- Applied changes in info folder
- Removed unneeded docs
- Removed delegate section
- Changed images
- Added gam native integration info
@KostiantynTselykh KostiantynTselykh force-pushed the MOBILE-7084_introduce_ios_integration_docs_for_rendering_module branch from d8d26b1 to 0456694 Compare June 2, 2021 17:01
@YuriyVelichkoOpenX YuriyVelichkoOpenX mentioned this pull request Jun 7, 2021
Closed
YuriyVelichkoOpenX and others added 3 commits June 9, 2021 15:44
@YuriyVelichkoOpenX
doc: corrections
5b4bb27
@YuriyVelichkoOpenX
doc: corrections for the native ads
7d976c3
@KostiantynTselykh
doc (Android):
5ad4ed4 
- Applied changes to integration-prebid for gam
- Applied changes to integration-prebid for mopub
- Applied changes to integration-prebid for ppm
- Applied changes in info folder
- Removed unneeded docs
- Removed delegate section
- Changed images
- Added gam native integration info
@VadimKhohlovOpenX VadimKhohlovOpenX force-pushed the feature-rendering-module branch from 8ac5c3f to 5216078 Compare June 14, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VadimKhohlovOpenX VadimKhohlovOpenX Awaiting requested review from VadimKhohlovOpenX

@YuriyVelichkoOpenX YuriyVelichkoOpenX Awaiting requested review from YuriyVelichkoOpenX

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KostiantynTselykh @xvadim12 @VadimKhohlovOpenX @YuriyVelichkoOpenX