Skip to content

In a previous change, we throw an error if we encounter an unknown sharding when saving shardings for instructions. However, this ingored the fact that we deliberately replace some module parameter/root shardings with unknown sharding objects. This CL makes the condition tigher so we only throw an error when we encounter unknown sharding objects intended for shard_as or shard_like annotations, which was the original intention anyway. #42161

In a previous change, we throw an error if we encounter an unknown sharding when saving shardings for instructions. However, this ingored the fact that we deliberately replace some module parameter/root shardings with unknown sharding objects. This CL makes the condition tigher so we only throw an error when we encounter unknown sharding objects intended for shard_as or shard_like annotations, which was the original intention anyway.

In a previous change, we throw an error if we encounter an unknown sharding when saving shardings for instructions. However, this ingored the fact that we deliberately replace some module parameter/root shardings with unknown sharding objects. This CL makes the condition tigher so we only throw an error when we encounter unknown sharding objects intended for shard_as or shard_like annotations, which was the original intention anyway. #42161

Triggered via pull request September 27, 2024 20:54
Status Success
Total duration 31s
Artifacts

buildifier.yml

on: pull_request
buildifier-lint
22s
buildifier-lint
Fit to window
Zoom out
Zoom in

Annotations

2 warnings
buildifier-lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@e2f20e631ae6d7dd3b768f56a5d2af784dd54791. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
buildifier-lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@e2f20e631ae6d7dd3b768f56a5d2af784dd54791. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/