Add a missing log to log error if XLA_PJRT_GPU_ALLOW_DELETE_BEFORE_FU…

…LFILL fails to read. PiperOrigin-RevId: 678926392
openxla · Sep 26, 2024 · 0032f7c · 0032f7c
1 parent 6777cef
commit 0032f7c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/xla/pjrt/BUILD b/xla/pjrt/BUILD
@@ -157,6 +157,7 @@ cc_library(
         "@com_google_absl//absl/strings:str_format",
         "@com_google_absl//absl/synchronization",
         "@tsl//tsl/platform:errors",
+        "@tsl//tsl/platform:logging",
         "@tsl//tsl/platform:statusor",
         "@tsl//tsl/profiler/lib:traceme",
         "@tsl//tsl/protobuf:error_codes_proto_impl_cc",

diff --git a/xla/pjrt/local_device_state.cc b/xla/pjrt/local_device_state.cc
@@ -30,6 +30,7 @@ limitations under the License.
 #include "xla/tsl/util/env_var.h"
 #include "xla/util.h"
 #include "tsl/platform/errors.h"
+#include "tsl/platform/logging.h"
 #include "tsl/platform/statusor.h"
 #include "tsl/profiler/lib/traceme.h"
 #include "tsl/protobuf/error_codes.pb.h"
@@ -61,6 +62,10 @@ LocalDeviceState::LocalDeviceState(se::StreamExecutor* executor,
   absl::Status status =
       tsl::ReadBoolFromEnvVar("XLA_PJRT_GPU_ALLOW_DELETE_BEFORE_FULFILL", true,
                               &allow_delete_before_fulfill_);
+  if (!status.ok()) {
+    LOG(ERROR) << "Failed to read XLA_PJRT_GPU_ALLOW_DELETE_BEFORE_FULFILL: "
+               << status;
+  }
 
   local_hardware_id_ = executor_->device_ordinal();
   local_device_id_ =