Skip to content

Commit

Permalink
[HLO Componentization] Create hlo/parser sub-component (Phase I).
Browse files Browse the repository at this point in the history
This CL takes care of
1. Migrating xla/hlo_parser* and xla/hlo_pexer* --> xla/hlo/parser
2. Setting up build aliases for xla/hlo_[parser|lexer]* ensuring external dependencies are still satisfied.

Phase II will take care of migration of external projects dependencies from  xla/hlo_[parser|lexer]* --> xla/hlo/parser

PiperOrigin-RevId: 678897485
  • Loading branch information
sdasgup3 authored and Google-ML-Automation committed Sep 27, 2024
1 parent 7d3676c commit 0722337
Show file tree
Hide file tree
Showing 9 changed files with 464 additions and 375 deletions.
115 changes: 115 additions & 0 deletions xla/hlo/parser/BUILD
Original file line number Diff line number Diff line change
@@ -0,0 +1,115 @@
# Description:
# XLA parser implementation.

load("@tsl//tsl/platform:rules_cc.bzl", "cc_library")
load(
"//xla:xla.bzl",
"xla_cc_test",
)
load("//xla/tsl:tsl.bzl", "internal_visibility")

package(
# copybara:uncomment default_applicable_licenses = ["//tensorflow:license"],
default_visibility = internal_visibility([":friends"]),
licenses = ["notice"],
)

package_group(
name = "friends",
includes = [
"//xla:friends",
],
)

cc_library(
name = "hlo_parser",
srcs = ["hlo_parser.cc"],
hdrs = ["hlo_parser.h"],
deps = [
":hlo_lexer",
"//xla:array",
"//xla:comparison_util",
"//xla:literal",
"//xla:literal_util",
"//xla:shape_layout",
"//xla:shape_util",
"//xla:types",
"//xla:util",
"//xla:xla_data_proto_cc",
"//xla/hlo/ir:hlo",
"//xla/hlo/ir:tile_assignment",
"//xla/service:computation_layout",
"//xla/service:hlo_module_config",
"//xla/service:hlo_proto_cc",
"//xla/service:name_uniquer",
"//xla/service:shape_inference",
"//xla/tsl/lib/gtl:map_util",
"@com_google_absl//absl/algorithm:container",
"@com_google_absl//absl/base",
"@com_google_absl//absl/container:flat_hash_map",
"@com_google_absl//absl/container:flat_hash_set",
"@com_google_absl//absl/container:inlined_vector",
"@com_google_absl//absl/functional:function_ref",
"@com_google_absl//absl/status",
"@com_google_absl//absl/status:statusor",
"@com_google_absl//absl/strings",
"@com_google_absl//absl/strings:str_format",
"@com_google_absl//absl/types:span",
"@eigen_archive//:eigen3",
"@tsl//tsl/platform:errors",
"@tsl//tsl/platform:logging",
"@tsl//tsl/platform:status",
],
)

xla_cc_test(
name = "hlo_parser_test",
size = "small",
srcs = ["hlo_parser_test.cc"],
deps = [
":hlo_lexer",
":hlo_parser",
"//xla:array",
"//xla:shape_util",
"//xla:window_util",
"//xla:xla_data_proto_cc",
"//xla/hlo/ir:hlo",
"//xla/service:hlo_module_config",
"//xla/service:pattern_matcher",
"//xla/service:pattern_matcher_gmock",
"//xla/tests:verified_hlo_module",
"//xla/tests:xla_internal_test_main",
"//xla/tsl/lib/core:status_test_util",
"@com_google_absl//absl/log",
"@com_google_absl//absl/status",
"@com_google_absl//absl/status:statusor",
"@com_google_absl//absl/strings",
"@com_google_absl//absl/types:span",
"@com_google_googletest//:gtest",
"@tsl//tsl/platform:errors",
"@tsl//tsl/platform:status_matchers",
"@tsl//tsl/platform:statusor",
"@tsl//tsl/platform:test",
],
)

cc_library(
name = "hlo_lexer",
srcs = ["hlo_lexer.cc"],
hdrs = [
"hlo_lexer.h",
],
deps = [
"//xla:shape_util",
"//xla:util",
"//xla:xla_data_proto_cc",
"@com_google_absl//absl/base",
"@com_google_absl//absl/log",
"@com_google_absl//absl/log:check",
"@com_google_absl//absl/status:statusor",
"@com_google_absl//absl/strings",
"@tsl//tsl/platform:logging",
"@tsl//tsl/platform:numbers",
"@tsl//tsl/platform:regexp",
],
)
2 changes: 1 addition & 1 deletion xla/service/hlo_lexer.cc → xla/hlo/parser/hlo_lexer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ See the License for the specific language governing permissions and
limitations under the License.
==============================================================================*/

#include "xla/service/hlo_lexer.h"
#include "xla/hlo/parser/hlo_lexer.h"

#include <cstdint>
#include <cstring>
Expand Down
218 changes: 218 additions & 0 deletions xla/hlo/parser/hlo_lexer.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,218 @@
/* Copyright 2017 The OpenXLA Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
==============================================================================*/

#ifndef XLA_HLO_PARSER_HLO_LEXER_H_
#define XLA_HLO_PARSER_HLO_LEXER_H_

#include <cstdint>
#include <optional>
#include <string>
#include <utility>

#include "absl/strings/string_view.h"
#include "xla/xla_data.pb.h"
#include "tsl/platform/logging.h"
#include "tsl/platform/regexp.h"

namespace xla {

// Defines different kinds of tokens used by the HLO lexer.
//
// You shouldn't need to use this directly unless you're using HloLexer
// directly, and you probably don't need to do that. Use hlo_parser instead.
enum class TokKind {
// Markers
kEof,
kError,

// Tokens with no info.
kEqual, // =
kComma, // ,
kColon, // :
kAsterisk, // *
kQuestionMark, // ?
kOctothorp, // #
kPlus, // +
kTilde, // ~
kLsquare,
kRsquare, // [ ]
kLbrace,
kRbrace, // { }
kLparen,
kRparen, // ( )
kDots, // ...

kArrow, // ->
kLeq, // <=

// Keywords
kw_HloModule,
kw_ENTRY,
kw_ROOT,
kw_true,
kw_false,
kw_maximal,
kw_replicated,
kw_manual,
kw_last_tile_dim_replicate,
kw_shard_as,
kw_shard_like,
kw_unknown,
kw_inf,

kNegInf, // -inf

// Typed tokens.
kPrimitiveType, // F32, PRED, etc.
kName, // %foo
kAttributeName, // dimensions=
kDimLabels, // [0-9bf?]{2,}_[0-9io?]{2,}->[0-9bf?]{2,}
kDxD, // [0-9]+(x[0-9]+)+
kPad, // [0-9]+_[0-9]+(_[0-9]+)?(x[0-9]+_[0-9]+(_[0-9]+)?)*
kSparsityDesc, // ([LR]\.[0-9]+@[0-9]+:[0-9]+_?)+
kIdent, // other identifiers
kString, // "abcd\"\n"
kInt, // 42
kDecimal, // 4.2
};

std::string TokKindToString(TokKind kind);

// Lexer for the HloModule::ToString() format text.
//
// This class is meant to be used by hlo_parser.cc. You shouldn't need to use
// it directly.
class HloLexer {
public:
explicit HloLexer(absl::string_view buf) : buf_(buf) {
current_ptr_ = buf_.data();
}

TokKind Lex() { return token_state_.current_kind = LexToken(); }

TokKind GetKind() const { return token_state_.current_kind; }
std::string GetStrVal() const {
switch (GetKind()) {
case TokKind::kName:
case TokKind::kAttributeName:
case TokKind::kDimLabels:
case TokKind::kDxD:
case TokKind::kPad:
case TokKind::kSparsityDesc:
case TokKind::kString:
case TokKind::kIdent:
return token_state_.str_val;
default:
LOG(FATAL) << "This token does not have string value";
}
}
int64_t GetInt64Val() const {
CHECK(GetKind() == TokKind::kInt) << TokKindToString(GetKind());
return token_state_.int64_val;
}
double GetDecimalVal() const {
CHECK(GetKind() == TokKind::kDecimal);
return token_state_.decimal_val;
}
PrimitiveType GetPrimitiveTypeVal() const {
CHECK(GetKind() == TokKind::kPrimitiveType);
return token_state_.primitive_type_val;
}

typedef const char* LocTy;

// Returns the location of the current token.
LocTy GetLoc() const { return token_state_.token_start; }

// Returns the line and column of a location in the buffer.
std::pair<unsigned, unsigned> GetLineAndColumn(LocTy location) const;

// Returns the whole line given the location.
absl::string_view GetLine(LocTy loc) const;

// Looks ahead one token and returns it. Lexer state is unchanged.
TokKind LookAhead();

// Lexes a string delimited by matching curly braces. Curlies contained
// inside double quotes don't count.
//
// Requires that you've already lexed the open curly brace.
//
// The returned string value includes the outer curlies.
//
// Returns TokKind::kString on success.
TokKind LexJsonDict();

private:
// Returns the current character. If it's neither the end of input buffer nor
// an invalid character, moves the pointer forward.
int GetNextChar();

// Returns the current character.
int PeekCurrentChar() const;

// Creates string_view with the given begin and end. Exits if the begin > end,
// or it's out of the range of the current buffer.
absl::string_view StringViewFromPointers(const char* begin,
const char* end) const;

// Returns true if the given ptr is dereferenceable within the range of the
// current buffer.
bool CanDereference(const char* ptr) const;

TokKind LexToken();

TokKind LexIdentifier();
TokKind LexPercent();
TokKind LexShape();
TokKind LexConstant();
TokKind LexNumberOrPattern();
TokKind LexString();

std::optional<int64_t> LexNanPayload(absl::string_view& consumable);

absl::string_view buf_;
const char* current_ptr_;

// Information about the current token.
struct TokenState {
const char* token_start = nullptr;
TokKind current_kind;
std::string str_val;
int64_t int64_val;
double decimal_val;
PrimitiveType primitive_type_val;
};
TokenState token_state_;

struct LineNoCacheTy {
const char* last_query;
unsigned line_no_of_query;
};
// This caches the line number of the previous query.
mutable LineNoCacheTy line_no_cache_{nullptr, 0};
};

// Does this string start with "{", end with "}", and contain valid-ish JSON
// in-between? If so, hlo_parser can parse e.g. backend_config={blah: "blah"}
// instead of the much uglier backend_config="{blah: \"blah\"}".
//
// (Technically we're not checking for fully-valid JSON, just something we can
// find the end of reasonably.)
bool LexesAsJsonDict(absl::string_view str);

} // namespace xla

#endif // XLA_HLO_PARSER_HLO_LEXER_H_
4 changes: 2 additions & 2 deletions xla/service/hlo_parser.cc → xla/hlo/parser/hlo_parser.cc
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ See the License for the specific language governing permissions and
limitations under the License.
==============================================================================*/

#include "xla/service/hlo_parser.h"
#include "xla/hlo/parser/hlo_parser.h"

#include <cmath>
#include <complex>
Expand Down Expand Up @@ -60,14 +60,14 @@ limitations under the License.
#include "xla/hlo/ir/hlo_sharding.h"
#include "xla/hlo/ir/hlo_sharding_metadata.h"
#include "xla/hlo/ir/tile_assignment.h"
#include "xla/hlo/parser/hlo_lexer.h"
#include "xla/layout.h"
#include "xla/layout_util.h"
#include "xla/literal.h"
#include "xla/literal_util.h"
#include "xla/primitive_util.h"
#include "xla/service/computation_layout.h"
#include "xla/service/hlo.pb.h"
#include "xla/service/hlo_lexer.h"
#include "xla/service/hlo_module_config.h"
#include "xla/service/name_uniquer.h"
#include "xla/service/shape_inference.h"
Expand Down
Loading

0 comments on commit 0722337

Please sign in to comment.