Destroy distributed client before service to avoid shutdown errors.

PiperOrigin-RevId: 679005510
openxla · Sep 26, 2024 · a61fd94 · a61fd94
1 parent 7e2ff2b
commit a61fd94
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/xla/tools/multihost_hlo_runner/create_client.h b/xla/tools/multihost_hlo_runner/create_client.h
@@ -31,8 +31,9 @@ limitations under the License.
 namespace xla {
 
 struct PjRtEnvironment {
-  std::unique_ptr<xla::PjRtClient> client;
+  // Sequence matters here, client should be destroyed before service.
   std::unique_ptr<xla::DistributedRuntimeService> service;
+  std::unique_ptr<xla::PjRtClient> client;
   std::shared_ptr<xla::KeyValueStoreInterface> kv_store;
   std::shared_ptr<xla::DistributedRuntimeClient> distributed_client;
 };