PR #17319: Fixes XLA build with numpy>=2.1.0 #17713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
Imported from GitHub PR #17319 When building XLA using the command from dev guide: docs/developer_guide.md ```bash ./configure.py --backend=CPU bazel build --test_output=all --spawn_strategy=sandboxed //xla/... ``` Using numpy==2.1.0 we can have the following linking error: ``` ERROR: /xla/xla/python/BUILD:1453:11: Linking xla/python/libnb_numpy.so failed: (Exit 1): clang failed: error executing command (from target //xla/python:nb_numpy) /usr/lib/llvm-14/bin/clang @bazel-out/k8-opt/bin/xla/python/libnb_numpy.so-2.params Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging ld.lld: error: undefined hidden symbol: _xla_numpy_api >>> referenced by nb_numpy.cc >>> bazel-out/k8-opt/bin/xla/python/_objs/nb_numpy/nb_numpy.pic.o:(xla::nb_dtype::from_args(nanobind::object const&)) >>> referenced by nb_numpy.cc >>> bazel-out/k8-opt/bin/xla/python/_objs/nb_numpy/nb_numpy.pic.o:(xla::nb_numpy_ndarray::nb_numpy_ndarray(xla::nb_dtype, absl::lts_20230802::Span<long const>, std::optional<absl::lts_20230802::Span<long const> >, void const*, nanobind::handle)) >>> referenced by nb_numpy.cc >>> bazel-out/k8-opt/bin/xla/python/_objs/nb_numpy/nb_numpy.pic.o:(xla::nb_numpy_ndarray::nb_numpy_ndarray(xla::nb_dtype, absl::lts_20230802::Span<long const>, std::optional<absl::lts_20230802::Span<long const> >, void const*, nanobind::handle)) >>> referenced 4 more times ld.lld: error: undefined hidden symbol: _xla_numpy_apiPyArray_RUNTIME_VERSION >>> referenced by nb_numpy.cc >>> bazel-out/k8-opt/bin/xla/python/_objs/nb_numpy/nb_numpy.pic.o:(xla::nb_numpy_ndarray::itemsize() const) clang: error: linker command failed with exit code 1 (use -v to see invocation) ``` Which should be related to https://github.com/numpy/numpy/blob/main/doc/source/release/2.1.0-notes.rst#api-symbols-now-hidden-but-customizable This PR fixes the build issue Copybara import of the project: -- 2f6e1b3 by vfdev-5 <[email protected]>: Fixes XLA build with numpy>=2.1.0 When building XLA using the command from dev guide: docs/developer_guide.md ```bash ./configure.py --backend=CPU bazel build --test_output=all --spawn_strategy=sandboxed //xla/... ``` Using numpy==2.1.0 we can have the following linking error: ``` ERROR: /xla/xla/python/BUILD:1453:11: Linking xla/python/libnb_numpy.so failed: (Exit 1): clang failed: error executing command (from target //xla/python:nb_numpy) /usr/lib/llvm-14/bin/clang @bazel-out/k8-opt/bin/xla/python/libnb_numpy.so-2.params Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging ld.lld: error: undefined hidden symbol: _xla_numpy_api >>> referenced by nb_numpy.cc >>> bazel-out/k8-opt/bin/xla/python/_objs/nb_numpy/nb_numpy.pic.o:(xla::nb_dtype::from_args(nanobind::object const&)) >>> referenced by nb_numpy.cc >>> bazel-out/k8-opt/bin/xla/python/_objs/nb_numpy/nb_numpy.pic.o:(xla::nb_numpy_ndarray::nb_numpy_ndarray(xla::nb_dtype, absl::lts_20230802::Span<long const>, std::optional<absl::lts_20230802::Span<long const> >, void const*, nanobind::handle)) >>> referenced by nb_numpy.cc >>> bazel-out/k8-opt/bin/xla/python/_objs/nb_numpy/nb_numpy.pic.o:(xla::nb_numpy_ndarray::nb_numpy_ndarray(xla::nb_dtype, absl::lts_20230802::Span<long const>, std::optional<absl::lts_20230802::Span<long const> >, void const*, nanobind::handle)) >>> referenced 4 more times ld.lld: error: undefined hidden symbol: _xla_numpy_apiPyArray_RUNTIME_VERSION >>> referenced by nb_numpy.cc >>> bazel-out/k8-opt/bin/xla/python/_objs/nb_numpy/nb_numpy.pic.o:(xla::nb_numpy_ndarray::itemsize() const) clang: error: linker command failed with exit code 1 (use -v to see invocation) ``` Which should be related to https://github.com/numpy/numpy/blob/main/doc/source/release/2.1.0-notes.rst#api-symbols-now-hidden-but-customizable This PR fixes the build issue Merging this change closes #17319 COPYBARA_INTEGRATE_REVIEW=#17319 from vfdev-5:fix-build-numpy-2.1.0-and-later 2f6e1b3 PiperOrigin-RevId: 679594145
copybara-service
bot
force-pushed
the
test_679581908
branch
from
052fb96
to
3ccf821
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #17319: Fixes XLA build with numpy>=2.1.0
Imported from GitHub PR #17319
When building XLA using the command from dev guide: docs/developer_guide.md
Using numpy==2.1.0 we can have the following linking error:
Which should be related to https://github.com/numpy/numpy/blob/main/doc/source/release/2.1.0-notes.rst#api-symbols-now-hidden-but-customizable
This PR fixes the build issue
Copybara import of the project:
--
2f6e1b3 by vfdev-5 [email protected]:
Fixes XLA build with numpy>=2.1.0
When building XLA using the command from dev guide: docs/developer_guide.md
Using numpy==2.1.0 we can have the following linking error:
Which should be related to https://github.com/numpy/numpy/blob/main/doc/source/release/2.1.0-notes.rst#api-symbols-now-hidden-but-customizable
This PR fixes the build issue
Merging this change closes #17319
FUTURE_COPYBARA_INTEGRATE_REVIEW=#17319 from vfdev-5:fix-build-numpy-2.1.0-and-later 2f6e1b3