Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork xla::ExecuteOptions into xla::ifrt::ExecuteOptions #17725

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Sep 28, 2024

  1. Fork xla::ExecuteOptions into xla::ifrt::ExecuteOptions

    Only the fields that are currently being used by any IFRT implementation are copied to the fork. Two fields that are currently being used as a passthrough in PjRt-IFRT but are removed are:
    
    * `untuple_result`: Since IFRT does not have XLA tuple types, all PjRt-IFRT invocations must have already been setting this to true. So this CL changes PjRt-IFRT to unconditionally set `untuple_result` to true when invoking PjRt and gets rid of this field from `xla.ifrt.ExecuteOptions`.
    * `use_major_to_minor_data_layout_for_callbacks`: The meaning of this field is very specific to PjRt. Since this field is set to true in every IFRT invocation that cares about this field, this CL instead changes PjRt-IFRT to internally always set this field to true and avoid exposing this to IFRT.
    
    In order to not break the IFRT Proxy's version compatibility, the forked `ExecuteOptionsProto` uses the same field tags as the original proto.
    
    PiperOrigin-RevId: 679727285
    junwhanahn authored and Google-ML-Automation committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    3a62a9d View commit details
    Browse the repository at this point in the history