[IFRT] Add Client::GetAllDevices() #17728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_679748878
branch
12 times, most recently
from
d77f485
to
1532a40
Compare
copybara-service
bot
force-pushed
the
test_679748878
branch
3 times, most recently
from
b021172
to
5db9b92
Compare
This defines `Client::GetAllDevices()`. It is similar to `Client::devices()`, but it enumerates all devices available on the client, regardless of the type/kind of devices. This multi-device behavior was implemented on certain IFRT implementations, and PjRt-IFRT would return the same devices for now because it has only one PjRt client. In the future, however, PjRt-IFRT would support multiple device types and it `GetAllDevices()` will return more devices while `devices()` may keep returning the devices of the primary device type/kind. `Client::GetAllDevices()` is essentially a transitional API in that its role will be absorbed back to `Client::devices()` by making `Client::devices()` also return all devices. However, this can only happen after the user code has been updated to apply device filtering so that the legacy behavior around using `Client::devices()` remains unchanged. By having a separate `Client::GetAllDevices()` while the transition happens, we can incrementally migrate the user code to apply the device filtering. PiperOrigin-RevId: 682504020
copybara-service
bot
force-pushed
the
test_679748878
branch
from
5db9b92
to
54f3498
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[IFRT] Add Client::GetAllDevices()
This defines
Client::GetAllDevices(). It is similar toClient::devices(),but it enumerates all devices available on the client, regardless of the
type/kind of devices. This multi-device behavior was implemented on certain
IFRT implementations, and PjRt-IFRT would return the same devices for now
because it has only one PjRt client. In the future, however, PjRt-IFRT would
support multiple device types and it
GetAllDevices()will return more deviceswhile
devices()may keep returning the devices of the primary devicetype/kind.
Client::GetAllDevices()is essentially a transitional API in that its rolewill be absorbed back to
Client::devices()by makingClient::devices()alsoreturn all devices. However, this can only happen after the user code has been
updated to apply device filtering so that the legacy behavior around using
Client::devices()remains unchanged. By having a separateClient::GetAllDevices()while the transition happens, we can incrementallymigrate the user code to apply the device filtering.