Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XLA:GPU] Rename uint32_count to uint8_count in GPUDriver::AsynchronousMemsetUint8 #17737

Closed
wants to merge 1 commit into from
Closed

[XLA:GPU] Rename uint32_count to uint8_count in GPUDriver::AsynchronousMemsetUint8 #17737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions xla/stream_executor/cuda/cuda_driver.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1079,10 +1079,10 @@ absl::Status GpuDriver::SynchronousMemsetUint32(Context* context,
absl::Status GpuDriver::AsynchronousMemsetUint8(Context* context,
CUdeviceptr location,
uint8_t value,
size_t uint32_count,
size_t uint8_count,
CUstream stream) {
ScopedActivateContext activation(context);
return cuda::ToStatus(cuMemsetD8Async(location, value, uint32_count, stream),
return cuda::ToStatus(cuMemsetD8Async(location, value, uint8_count, stream),
"Failed to enqueue async memset operation");
}

Expand Down
2 changes: 1 addition & 1 deletion xla/stream_executor/gpu/gpu_driver.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,7 @@ class GpuDriver {
static absl::Status AsynchronousMemsetUint8(Context* context,
GpuDevicePtr location,
uint8_t value,
size_t uint32_count,
size_t uint8_count,
GpuStreamHandle stream);

// Performs an asynchronous memset of the device memory segment via
Expand Down
4 changes: 2 additions & 2 deletions xla/stream_executor/rocm/rocm_driver.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -956,11 +956,11 @@ absl::Status GpuDriver::SynchronousMemsetUint32(Context* context,
absl::Status GpuDriver::AsynchronousMemsetUint8(Context* context,
hipDeviceptr_t location,
uint8 value,
size_t uint32_count,
size_t uint8_count,
GpuStreamHandle stream) {
ScopedActivateContext activation{context};
RETURN_IF_ROCM_ERROR(
wrap::hipMemsetAsync(location, value, uint32_count, stream),
wrap::hipMemsetAsync(location, value, uint8_count, stream),
"Failed to enqueue async memset operation");
return absl::OkStatus();
}
Expand Down