[nfc] Cleaning up dynamic slice fusion #19313
Open
+4
−501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezhulenev
reviewed
Nov 13, 2024
| explicit OffsetArray(const Literal& l); | ||
| OffsetArray(const OffsetArray& other) { values = other.values; } | ||
| }; | ||
|
|
||
| // Dynamic slice offset can be either: (1) a statically known constant value, |
shraiysh
force-pushed
the
cleanup-dynamic-slice-fusion
branch
from
58926db
to
3dc7d8a
Compare
Offset arrays and loop iteration offset are no longer handled in `xla/service/gpu/fusions/custom.cc`. Removing that to simplify the code. We are working on better handling with runtime computation of offset on the host.
ezhulenev
approved these changes
Nov 15, 2024
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 15, 2024
Imported from GitHub PR #19313 Offset arrays and loop iteration offset are no longer handled in `xla/service/gpu/fusions/custom.cc`. Removing that to simplify the code. We are working on better handling with runtime computation of offset on the host. Copybara import of the project: -- 3dc7d8a by Shraiysh Vaishay <[email protected]>: [nfc] Cleaning up dynamic slice fusion Offset arrays and loop iteration offset are no longer handled in `xla/service/gpu/fusions/custom.cc`. Removing that to simplify the code. We are working on better handling with runtime computation of offset on the host. Merging this change closes #19313 FUTURE_COPYBARA_INTEGRATE_REVIEW=#19313 from shraiysh:cleanup-dynamic-slice-fusion 3dc7d8a PiperOrigin-RevId: 696986510
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Nov 15, 2024
Imported from GitHub PR openxla/xla#19313 Offset arrays and loop iteration offset are no longer handled in `xla/service/gpu/fusions/custom.cc`. Removing that to simplify the code. We are working on better handling with runtime computation of offset on the host. Copybara import of the project: -- 3dc7d8a9d274693e434040331cfe25d27566973d by Shraiysh Vaishay <[email protected]>: [nfc] Cleaning up dynamic slice fusion Offset arrays and loop iteration offset are no longer handled in `xla/service/gpu/fusions/custom.cc`. Removing that to simplify the code. We are working on better handling with runtime computation of offset on the host. Merging this change closes #19313 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#19313 from shraiysh:cleanup-dynamic-slice-fusion 3dc7d8a9d274693e434040331cfe25d27566973d PiperOrigin-RevId: 696986510
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offset arrays and loop iteration offset are no longer handled in
xla/service/gpu/fusions/custom.cc. Removing that to simplify the code. We are working on better handling with runtime computation of offset on the host.