Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ut by tongyilingma and fix some error message #2126

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

leossteven
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind feature

What this PR does / why we need it:

feat: add ut by tongyilingma and fix some error message

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@rambohe-ch

other Note

image

Copy link

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.85%. Comparing base (3713163) to head (ea79293).
Report is 32 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2126      +/-   ##
==========================================
+ Coverage   56.09%   58.85%   +2.75%     
==========================================
  Files         186      209      +23     
  Lines       18092    18924     +832     
==========================================
+ Hits        10149    11137     +988     
+ Misses       6910     6706     -204     
- Partials     1033     1081      +48     
Flag Coverage Δ
unittests 58.85% <100.00%> (+2.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rambohe-ch rambohe-ch added approved approved lgtm lgtm labels Aug 19, 2024
@rambohe-ch
Copy link
Member

/LGTM

@rambohe-ch rambohe-ch merged commit 3cff6f4 into openyurtio:master Aug 19, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants