[yurthub] support cache response for partial object metadata requests。 #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vie-serendipity PTAL |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2170 +/- ##
==========================================
+ Coverage 56.09% 59.05% +2.95%
==========================================
Files 186 211 +25
Lines 18092 19070 +978
==========================================
+ Hits 10149 11261 +1112
+ Misses 6910 6726 -184
- Partials 1033 1083 +50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rambohe-ch
force-pushed
the
support-partialobjectmetadata-requests
branch
from
3c7c926 to
667a6ee
Compare
pkg/yurthub/proxy/util/util.go
Outdated
| var gvk schema.GroupVersionKind | ||
| acceptHeader := req.Header.Get("Accept") | ||
| parts := strings.Split(acceptHeader, ";") | ||
| for _, part := range parts { |
There was a problem hiding this comment.
I noticed kubernetes use goautoneg to parse accept, I think that might be better to some corner cases.
clauses := goautoneg.ParseAccept(header)
rambohe-ch
force-pushed
the
support-partialobjectmetadata-requests
branch
from
667a6ee to
a5601c3
Compare
rambohe-ch
force-pushed
the
support-partialobjectmetadata-requests
branch
from
a5601c3 to
2c8b065
Compare
…, like the following request: curl -H "Accept: application/json;as=PartialObjectMetadataList;g=meta.k8s.io;v=v1" "$API_SERVER/apis/apiextensions.k8s.io/v1/customresourcedefinitions" Signed-off-by: rambohe-ch <[email protected]>
rambohe-ch
force-pushed
the
support-partialobjectmetadata-requests
branch
from
2c8b065 to
b92602e
Compare
|
|
/LGTM @rambohe-ch |
zyjhtangtang
approved these changes
Oct 21, 2024
zyjhtangtang
pushed a commit
to zyjhtangtang/openyurt
that referenced
this pull request
Oct 23, 2024
…, like the following request: (openyurtio#2170) curl -H "Accept: application/json;as=PartialObjectMetadataList;g=meta.k8s.io;v=v1" "$API_SERVER/apis/apiextensions.k8s.io/v1/customresourcedefinitions" Signed-off-by: rambohe-ch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
support cache response for partial object metadata requests, like the following request:
Which issue(s) this PR fixes:
Fixes #2121
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note