feat: disable nodelifecycle controller by default #2246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2246 +/- ##
==========================================
- Coverage 45.22% 45.18% -0.04%
==========================================
Files 422 422
Lines 28779 28779
==========================================
- Hits 13014 13005 -9
- Misses 14452 14460 +8
- Partials 1313 1314 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rambohe-ch
force-pushed
the
disable-nodelifecycle-by-default
branch
from
a5f4ef0 to
e4b0167
Compare
Signed-off-by: rambohe-ch <[email protected]>
rambohe-ch
force-pushed
the
disable-nodelifecycle-by-default
branch
from
e4b0167 to
c35c302
Compare
|
|
/LGTM |
zyjhtangtang
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
According to the proposal #2155 , we use endpoints/endpointslices webhook to replace the current design: improve nodelifecyle controller to manage pod ready status according to node autonomy settings.
so we plan to disable nodelifecycle controller by default in yurt-manager component, and we will remove this controller in the future version.
by the way, we also don't disable nodelifecycle controller in kube-controller-manager component anymore.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note