Skip to content
This repository has been archived by the owner on Nov 7, 2023. It is now read-only.

dp delete fix and finalizer process #40

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

huiwq1990
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

  1. when cr is deleted, the reconcile should return;
  2. the finalizer should be removed after edgex profile delete success;
  3. the yurt-device-controller should just delete devicev1alpha1.DeviceProfileFinalizer, not all of them;

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link

@huiwq1990: The label(s) kind/enhancement cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

  1. when cr is deleted, the reconcile should return;
  2. the finalizer should be removed after edgex profile delete success;
  3. the yurt-device-controller should just delete devicev1alpha1.DeviceProfileFinalizer, not all of them;

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: huiwq1990
To complete the pull request process, please assign qclc
You can assign the PR to them by writing /assign @qclc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch
Copy link
Member

/assign @wawlian @qclc

@lwmqwer lwmqwer requested review from wawlian and qclc July 13, 2022 03:00
@qclc
Copy link
Member

qclc commented Sep 14, 2022

please resolve conflicts in this pr. @huiwq1990

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants