Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Fix FreeBSD 13.4 STABLE build #16885

Merged
merged 1 commit into from
Dec 19, 2024
Merged

CI: Fix FreeBSD 13.4 STABLE build #16885

merged 1 commit into from
Dec 19, 2024

Conversation

mcmilk
Copy link
Contributor

@mcmilk mcmilk commented Dec 19, 2024 •
edited
Loading

Motivation and Context

In #16869 we added FreeBSD 13.4 STABLE, but forget the special thing, that the virtio nic within FreeBSD 13.x is buggy.

This fix adds the needed rtl8139 nic to the VM.

How Has This Been Tested?

CI looks fine now: https://github.com/mcmilk/zfs/actions/runs/12408213008/job/34639501752

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@mcmilk
CI: Fix FreeBSD 13.4 STABLE build
e43c678 
In openzfs#16869 we added FreeBSD 13.4 STABLE, but forget the special
thing, that the virtio nic within FreeBSD 13.x is buggy.

This fix adds the needed rtl8139 nic to the VM.

Signed-off-by: Tino Reichardt <[email protected]>
@amotin amotin added the Status: Accepted Ready to integrate (reviewed, tested) label Dec 19, 2024
@amotin amotin merged commit e5ac778 into openzfs:master Dec 19, 2024
17 of 18 checks passed
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Dec 29, 2024
@mcmilk @behlendorf
CI: Fix FreeBSD 13.4 STABLE build
166a7bc 
In openzfs#16869 we added FreeBSD 13.4 STABLE, but forget the special
thing, that the virtio nic within FreeBSD 13.x is buggy.

This fix adds the needed rtl8139 nic to the VM.

Reviewed-by: George Melikov <[email protected]>
Reviewed-by:  Alexander Motin <[email protected]>
Signed-off-by: Tino Reichardt <[email protected]>
Closes openzfs#16885
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amotin amotin amotin approved these changes

@gmelikov gmelikov gmelikov approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcmilk @gmelikov @amotin