Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing zfs_exit() when snapdir is disabled #16912

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Add missing zfs_exit() when snapdir is disabled #16912

merged 1 commit into from
Dec 31, 2024

Conversation

anodos325
Copy link
Contributor

@anodos325 anodos325 commented Dec 30, 2024 •
edited by amotin
Loading

zfs_vget doesn't zfs_exit when erroring out due to snapdir being disabled.

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@anodos325
Add missing zfs_exit() when snapdir is disabled
c29f0fb 
zfs_vget doesn't zfs_exit when erroring out due to snapdir
being disabled.

Signed-off-by: Andrew Walker <[email protected]>
@amotin amotin added the Status: Code Review Needed Ready for review and testing label Dec 30, 2024
@tonyhutter tonyhutter merged commit 25238ba into openzfs:master Dec 31, 2024
24 of 26 checks passed
@amotin amotin deleted the fix-missing-zfs-exit branch December 31, 2024 03:27
@amotin amotin added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Dec 31, 2024
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Jan 3, 2025
@anodos325 @behlendorf
Add missing zfs_exit() when snapdir is disabled (openzfs#16912)
679b164 
zfs_vget doesn't zfs_exit when erroring out due to snapdir
being disabled.

Signed-off-by: Andrew Walker <[email protected]>
Reviewed-by: @bmeagherix
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Ameer Hamza <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmeagherix bmeagherix bmeagherix approved these changes

@ixhamza ixhamza ixhamza approved these changes

@tonyhutter tonyhutter tonyhutter approved these changes

@amotin amotin amotin approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anodos325 @amotin @tonyhutter @ixhamza @bmeagherix