Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZTS: zfs_mount_all_fail leaves /var/tmp/testrootPIDNUM directory around #16914

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

tsoome
Copy link
Contributor

@tsoome tsoome commented Jan 2, 2025

Before we can remove test files, we need to unmount datasets used by test first.

See also: zfs_mount_all_mountpoints.ksh

Motivation and Context

Clean up left over files from zfstest.

Description

unmount datasets from test then clean up mountpoints.

How Has This Been Tested?

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Before we can remove test files, we need to unmount datasets
used by test first.

See also: zfs_mount_all_mountpoints.ksh

Signed-off-by: Toomas Soome <[email protected]>
Copy link
Member

@amotin amotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to make sense. I am just not sure about the irrelevant part about fscount. Right or not, but most of other tests I quickly checked use $ there also.

@amotin amotin added the Status: Code Review Needed Ready for review and testing label Jan 2, 2025
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. In ksh the "$" is optional within "(( ))" so either way should be fine.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jan 2, 2025
@behlendorf behlendorf merged commit 8dc15ef into openzfs:master Jan 2, 2025
25 of 26 checks passed
behlendorf pushed a commit that referenced this pull request Jan 2, 2025
Before we can remove test files, we need to unmount datasets
used by test first.

See also: zfs_mount_all_mountpoints.ksh

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Signed-off-by: Toomas Soome <[email protected]>
Closes #16914
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Jan 3, 2025
Before we can remove test files, we need to unmount datasets
used by test first.

See also: zfs_mount_all_mountpoints.ksh

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Signed-off-by: Toomas Soome <[email protected]>
Closes openzfs#16914
@tsoome tsoome deleted the zfs_mount_all_fail branch January 3, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants