-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix language query to fetch only based on codename #98
Conversation
beb022a
to
ea51155
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 608 616 +8
=========================================
+ Hits 608 616 +8
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense ; thank you.
What's with the formatting changes?
Regarding formatting, looks like black has changed some convention ^^ |
But the workflow checks for black on a pinned version… |
My fault, looks like I did not used the local version but my system one ... |
Passed the QA check anyway 👍 |
Rationale
Probably due to an upstream change (in Babel ?), languages
name
andnative
properties are not up-to-date anymore in the DB. Code was not properly handling this situation, probably assuming these properties will never change.Changes
code
name
andnative
) are updated if they have changed