Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #12

Merged
merged 7 commits into from
Feb 16, 2024
Merged

Small fixes #12

merged 7 commits into from
Feb 16, 2024

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Feb 14, 2024

Fix #10
Fix #11
Fix #13

Also upgrades to Python bootstrap 1.0 and activate strict types checks (should have been from the beginning) and corresponding type fixes.

Also includes small README enhancement (styling for readability)

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (be107f3) 100.00% compared to head (86e043e) 100.00%.
Report is 9 commits behind head on main.

❗ Current head 86e043e differs from pull request most recent head a9f255d. Consider uploading reports for the commit a9f255d to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #12   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          232       239    +7     
  Branches        63        64    +1     
=========================================
+ Hits           232       239    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 force-pushed the small_fixes branch 2 times, most recently from 291ca31 to e1997e9 Compare February 16, 2024 08:28
@benoit74 benoit74 marked this pull request as ready for review February 16, 2024 09:19
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ; I see #13 was fixed by adding a sample git config. I assume that's because we want to test retrieving from a gitconfig but do support no gitconfig. Deserves a comment IMO

@benoit74
Copy link
Collaborator Author

Good point, thank you.

@pytest.fixture
def root_folder(tmp_path: Path) -> str:
    """
    Returns a "virtual" root folder with a "virtual" git config

    Git config comes from the tests/configs/gitconfig file

    This is necessary to ensure tests run always with the same git configuration file,
    to avoid variability coming from:
    - tests ran on plain files (not linked to any git repo)
    - tests ran on a repository fork (e.g myuser/hatch-openzim)
    - tests ran with a different remote (nothing forces main remote to be named origin)
    """

@benoit74 benoit74 merged commit 2f7b38b into main Feb 16, 2024
8 checks passed
@benoit74 benoit74 deleted the small_fixes branch February 16, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants