Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more logs to execute_after action and fix indentation in logs #17

Merged
merged 3 commits into from
May 6, 2024

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented May 6, 2024

Fix #15
Fix #16
Upgrade dependencies (including using "new" additional-classifier setting of hatch-openzim to simplify pyproject.toml)

@benoit74 benoit74 self-assigned this May 6, 2024
stdout and stderr are merged since in any case they will both be
displayed + it might be usefull to have proper logs ordering (logs to
stdout and stderr might be interleaved)
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but PR title is misleading ; you're not fixing it, you're adding debug information.

@benoit74 benoit74 changed the title Fix execute_after issues Add more logs to execute_after action and fix indentation in logs May 6, 2024
@benoit74 benoit74 merged commit b0c18c5 into main May 6, 2024
8 checks passed
@benoit74 benoit74 deleted the fix_execute_after branch May 6, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

execute_after does not display detailled logs of stuff run Indentation of execute_after logs is too deep.
2 participants