Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix title and report #102

Merged
merged 4 commits into from
Mar 2, 2024
Merged

Fix title and report #102

merged 4 commits into from
Mar 2, 2024

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Mar 2, 2024

Fix #100

Changes

  • ZIM Title was still not OK
  • using the stats report was making the scraper crash
  • Fix exception logging making duplicates

@benoit74 benoit74 self-assigned this Mar 2, 2024
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 0.00%. Comparing base (ed0c0d7) to head (bbbbed5).

Files Patch % Lines
src/ifixit2zim/imager.py 0.00% 3 Missing ⚠️
src/ifixit2zim/scraper.py 0.00% 3 Missing ⚠️
src/ifixit2zim/utils.py 0.00% 3 Missing ⚠️
src/ifixit2zim/executor.py 0.00% 2 Missing ⚠️
src/ifixit2zim/scraper_generic.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #102   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         17      17           
  Lines       1665    1653   -12     
  Branches     293     292    -1     
=====================================
+ Misses      1665    1653   -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 merged commit 91fea6c into main Mar 2, 2024
7 checks passed
@benoit74 benoit74 deleted the fix_title_and_report branch March 2, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not fail on first progress report
1 participant