Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libzim 8.2.1 for release 0.3 #56

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

Jaifroid
Copy link
Collaborator

Closes #55.

@Jaifroid Jaifroid added build Code relating to building or publishing assets update Update dependencies labels Oct 12, 2023
@Jaifroid Jaifroid self-assigned this Oct 12, 2023
@Jaifroid Jaifroid requested a review from mgautierfr October 12, 2023 06:23
@Jaifroid
Copy link
Collaborator Author

@mgautierfr At long last, I'm updating the source for the javascript-libzim build to v8.2.1 of libzim. However, in the build log, I notice a bunch of deprecation warnings related to code in the bindings, starting here. Is this something I should be worried about? It looks like the bindings are depending on methods that have been marked for deprecation (I assume in libzim itself). If this is the case, then we could be looking at the build breaking once those methods disappear. Are there simple alternatives we can substitute?

@Jaifroid
Copy link
Collaborator Author

I've tested the wasm release artefact from this PR in kiwix/kiwix-js#766, and all seems to be working fine.

@Jaifroid
Copy link
Collaborator Author

Also builds correctly from source (without using libzim WASM binary, but building it from scratch) after updating zlib to v1.3.

@mgautierfr
Copy link
Collaborator

I notice a bunch of deprecation warnings related to code in the bindings, starting here. Is this something I should be worried about?

They are warning about libzim using cpp features which are deprecated in c++17.
Next release of libzim will have them fixed (it is already on master).
Nothing to worry about and nothing to do on your side (maybe compile in c++11)

@Jaifroid
Copy link
Collaborator Author

OK, thanks for the reassurance @mgautierfr!

@Jaifroid
Copy link
Collaborator Author

Confirmed that wasm build from source (without libzim.a) works fine too. So this is ready to merge, and I can prepare the new release.

@Jaifroid Jaifroid merged commit 7cc39da into main Oct 12, 2023
3 checks passed
@Jaifroid Jaifroid deleted the Update-libzim-8.2.1-for-release-0.3 branch October 12, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Code relating to building or publishing assets update Update dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update release for source build of libzim v8.2.1
2 participants