Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing f-string in setup.py #204

Closed
wants to merge 1 commit into from
Closed

Add missing f-string in setup.py #204

wants to merge 1 commit into from

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Sep 23, 2024

Otherwise you end up with:

Using found library at {config.found_libzim}. Adjust CFLAGS/LDFLAGS if needed

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.49%. Comparing base (1113083) to head (5d563d9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #204   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files           1        1           
  Lines         523      523           
=======================================
  Hits          489      489           
  Misses         34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42 kelson42 requested a review from rgaudin September 23, 2024 02:50
@kelson42 kelson42 added this to the 3.6.0 milestone Sep 23, 2024
@rgaudin
Copy link
Member

rgaudin commented Sep 23, 2024

Sorry I saw the branch and not the PR (my mistake) and thought you were not planning on pushing it. Already pushed it

@rgaudin rgaudin closed this Sep 23, 2024
@rgaudin rgaudin deleted the legoktm-patch-1 branch September 23, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants