Skip to content

Commit

Permalink
Merge pull request #221 from openzim/disable-subtitles-preloading
Browse files Browse the repository at this point in the history
Disable preloading of subtitles in video.js
  • Loading branch information
benoit74 authored Aug 5, 2024
2 parents a586a69 + 57069d0 commit 3d71c31
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed

- Change log level of "Video at {url} has not yet been translated into {requested_lang_code}" messages from warning to debug (way too verbose)
- Disable preloading of subtitles in video.js

### Fixed

Expand Down
2 changes: 1 addition & 1 deletion src/ted2zim/templates/article.html
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<video class="video-js vjs-default-skin vjs-fill"
controls preload="auto" playsinline
poster="videos/{{ video_id }}/thumbnail.webp"
data-setup='{"techOrder": ["html5", "ogvjs"], "ogvjs": {"base": "assets/ogvjs"}, "autoplay": {% if autoplay %}true{% else %}false{% endif %}, "preload": true, "controls": true, "controlBar": {"pictureInPictureToggle":false}}'>
data-setup='{"techOrder": ["html5", "ogvjs"], "html5": {"preloadTextTracks": false}, "ogvjs": {"base": "assets/ogvjs", "preloadTextTracks": false}, "autoplay": {% if autoplay %}true{% else %}false{% endif %}, "preload": true, "controls": true, "controlBar": {"pictureInPictureToggle":false}}'>
<source src="videos/{{ video_id }}/video.{{ video_format }}" type="video/{{ video_format }}" />
{% for language in languages %}
<track kind="subtitles" src="videos/{{ video_id }}/subs/subs_{{ language.languageCode }}.vtt" srclang="{{ language.languageCode }}" label="{{ language.languageName }}" />
Expand Down

0 comments on commit 3d71c31

Please sign in to comment.