retry video info extract on missing videoData #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elfkuzco is this ready for review? (do not mind about the failing test CI, this is "our" fault: openzim/_python-bootstrap#47) |
|
Yes, it is ready for review. Couldn't request for a review because of the failed actions |
benoit74
requested changes
Sep 17, 2024
benoit74
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Thank you, LGTM.
Now that review is over, please squash all three commits into one (we don't need to keep these details which are only linked to the way development happened and do not provide value for the future) and force push them to your branch. Once done, I will merge this branch.
elfkuzco
force-pushed
the
retry-on-missing-videoData
branch
from
52e2273
to
abecbcc
Compare
|
I have squashed the commits into one. |
benoit74
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Sometimes,
videoDatais missing in the__NEXT_DATA__data returned from the edX page. This PR retries such requests rather than throwing an error.This resolves #222
Changes
KeyErrorthrown when accessing thevideoDataand retry requestextract_info_from_video_page