Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to cssbeautifier and fix delays in category scraping #158

Merged
merged 4 commits into from
Feb 19, 2024
Merged

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Feb 16, 2024

Fix #151
Fix #157

Changes

  • Migrate from css-beautify to cssbeautifier
    • Fix in-line CSS data which was not detected correctly anymore
  • Add missing delay in category scraping and fix delay between pages

@benoit74 benoit74 self-assigned this Feb 16, 2024
@benoit74
Copy link
Collaborator Author

I'm not sure it will be a big game changer, but combined with pywikiapi changes, it will anyway enhance the situation.

@benoit74 benoit74 marked this pull request as ready for review February 16, 2024 16:36
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to say anything at the moment

@rgaudin
Copy link
Member

rgaudin commented Feb 16, 2024

We all those “small bugs” we'll need more meaningful PR names 😉

@benoit74 benoit74 changed the title Fix small bugs Move to cssbeautifier and fix delays in category scraping Feb 19, 2024
@benoit74
Copy link
Collaborator Author

Looks like I might have forgotten to update the issue title 🤪

@benoit74 benoit74 merged commit 4cd8498 into main Feb 19, 2024
4 checks passed
@benoit74 benoit74 deleted the fix_various branch February 19, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Category scraping in not honouring the configured delay css-beautify has been removed
2 participants