-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to create selections from Wikipedia books #645
Conversation
e13463c
to
011d71f
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #645 +/- ##
==========================================
- Coverage 96.42% 96.34% -0.08%
==========================================
Files 98 100 +2
Lines 7714 7831 +117
==========================================
+ Hits 7438 7545 +107
- Misses 276 286 +10
☔ View full report in Codecov by Sentry. |
@audiodude Does it grab title and subtitle? |
It does not. I didn't see that requirement in the bug. What would you expect to use this data for? Selections currently only store their article lists (in S3) and don't have fields for additional metadata. I assume you want to use title and subtitle for metadata in the ZIM? |
@audiodude yes yes yes |
Okay I think we should create a separate bug to track that work, since it is substantially more complicated than what's in this PR and would bloat this one (which is, of course, already finished). |
I'm thinking of something following from #640 as well, where we can surface more of the ZIM metadata on the ZIM page, under an optional expanding section, with some of it pre-populated based on the result of the selection materialization. |
011d71f
to
c74c8a8
Compare
cdcb5ab
to
bb4e5d1
Compare
…ix line endings, add validation tests
c74c8a8
to
c4cde64
Compare
Fixes #644.
Users can create selections based on a Wikipedia "book" url, such as https://en.wikipedia.org/wiki/User:Audiodude/Books/test. The Book Builder fetches the wikitext of the page that is saved by this tool and parses out the article names, then saves them in S3. A frontend is provided for creation of Book selections, which verifies that the URL is present, valid, and matches the project selected in the dropdown.
Book selections can be used to create ZIM files just like any other selection.