Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmatched quotes in config #714

Closed
rgaudin opened this issue Sep 19, 2022 · 2 comments
Closed

Unmatched quotes in config #714

rgaudin opened this issue Sep 19, 2022 · 2 comments

Comments

@rgaudin
Copy link
Member

rgaudin commented Sep 19, 2022

youzimit task has a favicon param of:

https://gmka.org/wp-content/uploads/2021/08/doctor-630x760.png"

This crashes the task worker which is something we should avoid.

[2022-09-13 21:39:11,395: INFO] Fetching task details for b343e30ef13291d2c58f0236
[2022-09-13 21:39:11,484: INFO] Updating task-status=started
[2022-09-13 21:39:11,685: INFO] Setting-up workdir
[2022-09-13 21:39:11,701: INFO] Starting DNS cache
[2022-09-13 21:39:12,401: DEBUG] DNS Cache started using IPs: ['172.17.0.7']
[2022-09-13 21:39:12,401: INFO] Starting scraper. Expects files at: /data/zimfarm/data/b343e30ef13291d2c58f0236 
[2022-09-13 21:39:12,408: DEBUG] Pulling image ghcr.io/openzim/zimit:dev
[2022-09-13 21:39:12,979: ERROR] Unhandled exception: No closing quotation
[2022-09-13 21:39:12,979: ERROR] No closing quotation
Traceback (most recent call last):
  File "/usr/local/bin/task-worker", line 60, in main
    sys.exit(worker.run())
  File "/usr/src/app/task/worker.py", line 641, in run
    self.start_scraper()
  File "/usr/src/app/task/worker.py", line 306, in start_scraper
    self.scraper = start_scraper(
  File "/usr/src/app/common/docker.py", line 419, in start_scraper
    return run_container(
  File "/usr/src/app/common/docker.py", line 91, in run_container
    return retried_docker_call(docker_client.containers.run, *args, **kwargs)
  File "/usr/src/app/common/docker.py", line 49, in retried_docker_call
    return docker_method(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/docker/models/containers.py", line 819, in run
    container = self.create(image=image, command=command,
  File "/usr/local/lib/python3.8/site-packages/docker/models/containers.py", line 878, in create
    resp = self.client.api.create_container(**create_kwargs)
  File "/usr/local/lib/python3.8/site-packages/docker/api/container.py", line 420, in create_container
    config = self.create_container_config(
  File "/usr/local/lib/python3.8/site-packages/docker/api/container.py", line 431, in create_container_config
    return ContainerConfig(self._version, *args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/docker/types/containers.py", line 701, in __init__
    command = split_command(command)
  File "/usr/local/lib/python3.8/site-packages/docker/utils/utils.py", line 464, in split_command
    return shlex.split(command)
  File "/usr/local/lib/python3.8/shlex.py", line 311, in split
    return list(lex)
  File "/usr/local/lib/python3.8/shlex.py", line 300, in __next__
    token = self.get_token()
  File "/usr/local/lib/python3.8/shlex.py", line 109, in get_token
    raw = self.read_token()
  File "/usr/local/lib/python3.8/shlex.py", line 191, in read_token
    raise ValueError("No closing quotation")
ValueError: No closing quotation
[2022-09-13 21:39:12,987: ERROR] exiting.
[2022-09-13 21:39:12,987: INFO] Trying to upload exception details
[2022-09-13 21:39:12,988: INFO] Updating task-status=failed
@stale
Copy link

stale bot commented May 26, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label May 26, 2023
@benoit74
Copy link
Collaborator

Duplicate of #668

@benoit74 benoit74 marked this as a duplicate of #668 Jun 21, 2024
@benoit74 benoit74 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants