Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape quotes in config #668

Open
kelson42 opened this issue Feb 2, 2022 · 3 comments
Open

Escape quotes in config #668

kelson42 opened this issue Feb 2, 2022 · 3 comments

Comments

@kelson42
Copy link
Contributor

kelson42 commented Feb 2, 2022

See https://farm.openzim.org/pipeline/a7e335828162de57f03eaf16/debug. It seems the description argument is not quoted properly! Or maybe this is a ticket for Zimfarm?

@kelson42 kelson42 pinned this issue Feb 2, 2022
@rgaudin rgaudin transferred this issue from openzim/wikihow Feb 3, 2022
@rgaudin
Copy link
Member

rgaudin commented Feb 3, 2022

Yes, that's not something the scraper can handle because it never reaches it. I transfered to zimfarm.

Although we haven't seen those, there are certainly legitimate use cases for this and it needs to be fixed but for this very recipe, it's not correct. I fixed it by using «Comment faire». Even for English, " is not appropriate ; and are.

@rgaudin rgaudin removed their assignment Feb 3, 2022
@rgaudin rgaudin changed the title Wikihow FR fails now Escape quotes in config Feb 3, 2022
@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
@benoit74
Copy link
Collaborator

Again impacted by this bug on openzim/zim-requests#1058

I think we must push this as prio1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants