doc(data): add micrometer as communitry tracer #180
Conversation
|
maybe @codefromthecrypt ? |
|
Thanks for the PR. Micrometer tracing is a different framework than sleuth, so should be similar, but a separate line. For example, micrometer tracing is integrated into Spring Boot 3 but sleuth is integrated into Spring boot 2. cc @making who may be able to help with details! |
|
Yes, that should be on a separate line. |
|
Thanks for the review, @codefromthecrypt and @making , pushed the suggested comments. Whenever you have got time .., feel free to push directly in this branch |
There was a problem hiding this comment.
@making gets the honorary approve for real as I haven't audited the other frameworks, but sounds legit ;)
| - language: Java | ||
| library: >- | ||
| [Micrometer Tracing](https://github.com/micrometer-metrics/tracing) | ||
| framework: Spring, Quarkus, Micronaut, Helidon |
There was a problem hiding this comment.
May seem like a nit, but I think this question has come up (what about Spring Boot 2)
| framework: Spring, Quarkus, Micronaut, Helidon | |
| framework: Spring Boot 3+, Quarkus, Micronaut, Helidon |
There was a problem hiding this comment.
technically, Spring Framework 6+
I'm not sure if Quarkus, Micronaut and Helidon support Micrometer Tracing besides Metrics.
For example, in the Helidon doc, only OpenTelemetry is referred.
https://helidon.io/docs/v4/mp/telemetry
There was a problem hiding this comment.
Updated to "Spring Framework 6+". About frameworks related ...?
There was a problem hiding this comment.
Quarkus, Micronaut, Helidon
Have you tested that it works?
If not, it's probably safe to remove the mention.
There was a problem hiding this comment.
Quarkus, Micronaut, Helidon
Have you tested that it works? If not, it's probably safe to remove the mention.
I have NOT had time to tested it. Should I remove it for safety reasons?
There was a problem hiding this comment.
I would remove them. Iooked at the other docs and unlike spring boot, there are no zipkin tracing integrations/registries/instructions in Quarkus, Micronaut, Helidon. The closest they come is otel, and that's stretch to say is a community integration for zipkin.
p.s. @making still think it should be about spring boot because spring itself has no zipkin integration. It is a bit misleading and inconsistent to say Spring Framework 6+ which doesn't have an integration path for zipkin, unless I'm missing something https://docs.spring.io/spring-boot/reference/actuator/tracing.html
There was a problem hiding this comment.
updated @codefromthecrypt
| - language: Java | ||
| library: >- | ||
| [Micrometer Tracing](https://github.com/micrometer-metrics/tracing) | ||
| framework: Spring, Quarkus, Micronaut, Helidon |
There was a problem hiding this comment.
technically, Spring Framework 6+
I'm not sure if Quarkus, Micronaut and Helidon support Micrometer Tracing besides Metrics.
For example, in the Helidon doc, only OpenTelemetry is referred.
https://helidon.io/docs/v4/mp/telemetry
|
one last comment and thanks for your patience on this @dancer1325 |
|
thanks again for your patience @dancer1325! |
Description
How to review?