-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds diagram showing trace instrumentation's role in architecture #71
Conversation
@guettli does this help? |
Looks much less boring than a sequence diagram .... on the other hand I like it boring. I like it boring since it is often a good, since most obvious, way. |
cbe7740
to
4190817
Compare
@guettli PTAL I hope this is more what you were looking for (also changed PR description) |
2693b10
to
7bb3e1b
Compare
@@ -33,6 +33,61 @@ Here's a diagram describing this flow: | |||
To see if an instrumentation library already exists for your platform, see the | |||
list of [existing instrumentations]({{ site.github.url}}/pages/existing_instrumentations). | |||
|
|||
Example flow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@openzipkin/core might want to take a look at this, too. The attempt here is to show the relationship of sorts of activity in scope of trace instrumentation. We've had plenty of requests to clarify this and probably does help to do so in the architecture pane vs requiring people to look at the instrumenting section.
IOTW, people simply using a zipkin system probably could do well to have a brief overview of the process.
thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adriancole This sequence diagram is easy to understand. Looks good, thank you. BTW, how did you "paint" it? What tool did you use?
Zipkin). | ||
|
||
Here's an example sequence of http tracing. Notice timing data is reported to | ||
Zipkin after the application response is completed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"after the application response" may also be accurate here, but I believe the diagram is trying to show the tracing of the HTTP call GET /foo
being made by "Application". Maybe it would be less confusing/more accurate to say "after the HTTP call is completed."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To that end, maybe it is best to explicitly state in the previous line:
Here's an example sequence of http tracing where "Application" is making an http call to GET /foo
that will be traced in a single span.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point.. above in the doc we do define the term Span.. good to reinforce
5b86209
to
df70e85
Compare
df70e85
to
dc331ef
Compare
did some rewording based on ideas from @shakuzen
then clarifying below the diagram why
Not sure if this is too much info for this section, but maybe it is ok? I chose "user code" instead of application as I didn't want folks to misunderstand application as something not in the same process. If the choice makes things worse, let me know |
as we can edit at anytime (in fact anyone can raise a PR), merged as I think this was good progress |
@adriancole <https://github.com/adriancole> This sequence diagram is easy
to understand. Looks good, thank you. BTW, how did you "paint" it? What
tool did you use?
I used monodraw which I'm just now getting familiar with. it is pretty good
and a bit better than what I used before. There's no built-in sequence
diagram, I just drew lines and boxes and moved them around etc.
Thanks for the feedback!
|
@adriancole off topic: I want to learn zipkin, I have question here at StackO: http://stackoverflow.com/questions/41508180/zipkin-for-profiling-traditional-progamm-one-process-one-thread if you have three minutes ... |
Adds a sequence diagram that shows instrumentation do things in band and out-of-band
See #68