Merge pull request #69 from jcchavezs/fixes_reporter_default_values

Fixes default values for reporter.
openzipkin · Mar 7, 2018 · b9fe432 · b9fe432
2 parents c5fed92 + a748854
commit b9fe432
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/src/Zipkin/Reporters/Http.php b/src/Zipkin/Reporters/Http.php
@@ -36,7 +36,7 @@ public function __construct(
     ) {
         $this->clientFactory = $requesterFactory ?: CurlFactory::create();
         $this->options = array_merge(self::DEFAULT_OPTIONS, $options);
-        $this->reportMetrics = $reporterMetrics;
+        $this->reportMetrics = $reporterMetrics ?: new NoopMetrics();
     }
 
     /**

diff --git a/src/Zipkin/Reporters/Http/CurlFactory.php b/src/Zipkin/Reporters/Http/CurlFactory.php
@@ -7,6 +7,10 @@
 
 final class CurlFactory implements ClientFactory
 {
+    private function __construct()
+    {
+    }
+
     /**
      * @return CurlFactory
      * @throws \BadFunctionCallException if the curl extension is not installed.

diff --git a/tests/Unit/Reporters/HttpTest.php b/tests/Unit/Reporters/HttpTest.php
@@ -16,6 +16,12 @@ final class HttpTest extends PHPUnit_Framework_TestCase
     const PAYLOAD = '[{"id":"%s","name":null,"traceId":"%s","parentId":null,'
         . '"timestamp":null,"duration":null,"debug":false,"localEndpoint":{"serviceName":""}}]';
 
+    public function testCreateHttpReporterWithDefaultDependencies()
+    {
+        $httpReporter = new Http();
+        $this->assertInstanceOf(Http::class, $httpReporter);
+    }
+
     public function testHttpReporterSuccess()
     {
         $context = TraceContext::createAsRoot();