Skip to content

Commit

Permalink
deps: removes accidental dependency management of zipkin-proto
Browse files Browse the repository at this point in the history
This was accidentally copy/pasted in #189 and not consumed here or in
brave.

Signed-off-by: Adrian Cole <[email protected]>
  • Loading branch information
Adrian Cole committed Dec 12, 2023
1 parent c4823c3 commit f514ece
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
6 changes: 0 additions & 6 deletions bom/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
<main.basedir>${project.basedir}/..</main.basedir>
<!-- use the same value in ../pom.xml -->
<zipkin.version>2.24.4</zipkin.version>
<zipkin-proto3.version>1.0.0</zipkin-proto3.version>
</properties>

<url>https://github.com/openzipkin/zipkin-reporter-java</url>
Expand Down Expand Up @@ -86,11 +85,6 @@
<artifactId>zipkin</artifactId>
<version>${zipkin.version}</version>
</dependency>
<dependency>
<groupId>io.zipkin.proto3</groupId>
<artifactId>zipkin-proto3</artifactId>
<version>${zipkin-proto3.version}</version>
</dependency>
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>zipkin-reporter</artifactId>
Expand Down
1 change: 0 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@

<!-- use the same value in bom/pom.xml -->
<zipkin.version>2.24.4</zipkin.version>
<zipkin-proto3.version>1.0.0</zipkin-proto3.version>

<!-- Do not set this value in bom/pom.xml to avoid cyclic pinning -->
<brave.version>5.16.0</brave.version>
Expand Down

0 comments on commit f514ece

Please sign in to comment.