Updates all test dependencies including CI and removes Retrolambda #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codefromthecrypt
force-pushed
the
build-update
branch
from
a667790 to
745c4b1
Compare
This updates all aspects of the build including GitHub Actions versions, maven versions and test dependency versions. Most notably, this allows use of Java 11-17. Main versions are left for a different change. To achieve this, we replace parts of the build that used RetroLambda to use maven profiles (similar to zipkin), as RetroLambda is no longer maintained. We also have to keep Java 11 in releases as later versions cannot compiler Java 1.6 bytecode anymore. Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
force-pushed
the
build-update
branch
from
745c4b1 to
d59cb55
Compare
anuraaga
approved these changes
Dec 11, 2023
Signed-off-by: Adrian Cole <[email protected]>
In many cases, the lambda part of retrolambda didn't work. I looked and there was an out-of-date comment to that affect I deleted. The main value we were getting was rewriting the bytecode after the fact. |
Signed-off-by: Adrian Cole <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates all aspects of the build including GitHub Actions versions, maven versions and test dependency versions. Most notably, this allows use of Java 11,17,21. Main versions are left for a different change.
To achieve this, we replace parts of the build that used RetroLambda to use maven profiles (similar to zipkin), as RetroLambda is no longer maintained. We also have to keep Java 11 in releases as later versions cannot compiler Java 1.6 bytecode anymore.