ci: moves ActiveMQ to docker based tests #220
Conversation
This replaces the in-VM approach for testing activemq which has been flakey and also results in a JUnit 4 rule dependency. Note: This uses the JDK image, not the JRE, because ActiveMQ relies on JMX even when disabled via configuration. This is a better choice than making our production JRE image include it. Once this is deployed I can make zipkin-reporter use it per below: openzipkin/zipkin-reporter-java#220 I can also change our collector tests here to use it instead of the JUnit 4 rule. Signed-off-by: Adrian Cole <[email protected]>
| return "failover:tcp://" + container.getHost() + ":" + container.getMappedPort(ACTIVEMQ_PORT); | ||
| } | ||
|
|
||
| // mostly waiting for https://github.com/testcontainers/testcontainers-java/issues/3537 |
There was a problem hiding this comment.
I think this may be copy-pasted and no need to change anything now, but just for reference, @TestContainers and @Container automatically skip when docker isn't available. It would look something like this, but don't think it's a priority to change anything
Rename ActiveMQExtension -> ActiveMQContainer
public static class ActiveMQContainer extends ... {
public ActiveMQContainer() {
...
}
public String newSenderBuilder(String queue) {
...
}
}
@Testcontainers
public class ITActiveMQSender {
@Container public static final activemq = new ActiveMQContainer();
...
}There was a problem hiding this comment.
does this also allow property override? in the main zipkin build we intentionally skip docker on one pass so we can parallelize them...
There was a problem hiding this comment.
I think if we could do what you said and still have a skip property (even if we make it), sounds much better and I can help sweep around and apply the pattern everywhere.
There was a problem hiding this comment.
I'll try a separate PR once this is in to do all of them. thanks for the tip @anuraaga!
…3636) This replaces the in-VM approach for testing activemq which has been flakey and also results in a JUnit 4 rule dependency. Note: This uses the JDK image, not the JRE, because ActiveMQ relies on JMX even when disabled via configuration. This is a better choice than making our production JRE image include it. Once this is deployed I can make zipkin-reporter use it per below: openzipkin/zipkin-reporter-java#220 I can also change our collector tests here to use it instead of the JUnit 4 rule. Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
force-pushed
the
activemq-docker
branch
from
35b781d to
8ebdf6c
Compare
this removes a junit 4 dependency as well