updates integration tests and benchmarks to use log4j #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <include>**/IT*.java</include> | ||
| </includes> | ||
| <!-- Try to prevent flakes in CI --> | ||
| <reuseForks>false</reuseForks> |
There was a problem hiding this comment.
moved config from our normal failsafe
| @@ -384,10 +406,6 @@ | |||
| <plugin> | |||
| <artifactId>maven-surefire-plugin</artifactId> | |||
| <version>${maven-surefire-plugin.version}</version> | |||
| <configuration> | |||
| <!-- Ensures root cause ends up in the console --> | |||
| <trimStackTrace>false</trimStackTrace> | |||
There was a problem hiding this comment.
this was a carry-over from zipkin with armeria
Similar to Brave, we don't want a large amount of clutter. To reduce a lot of it, I moved anything that uses MockWebServer to an IT (because it spams logs). I didn't move normal tests to log4j because we have a log capturing test that would fail. If someone wants to take a pass later at that, they could. Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
force-pushed
the
log4j
branch
from
6e7ab3d to
32d69a8
Compare
|
after this is in, I'll add invoker tests for the rabbitmq amqp-client which proves we can use recent versions and avoid CVE distraction while still maintaining compat (similar to okhttp). Finally, I'll do the same for spring and we're ready to roll ideally with no CVE scares. |
Signed-off-by: Adrian Cole <[email protected]>
anuraaga
approved these changes
Dec 14, 2023
|
Thanks for helping me consume so much Azure VM time @anuraaga! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to Brave, we don't want a large amount of clutter. To reduce a lot of it, I moved anything that uses MockWebServer to an IT (because it spams logs). I didn't move normal tests to log4j because we have a log capturing test that would fail. If someone wants to take a pass later at that, they could.