Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes openziti/ziti#1422 server cert chain assembly #51

Merged
merged 3 commits into from
Oct 23, 2023
Merged

fixes openziti/ziti#1422 server cert chain assembly #51

merged 3 commits into from
Oct 23, 2023

Conversation

andrewpmartinez
Copy link
Member

Chain assembly no longer accidentally pulls leafs from the CAs bundle.

@andrewpmartinez andrewpmartinez requested a review from a team as a code owner October 23, 2023 18:28
@plorenz
Copy link
Member

plorenz commented Oct 23, 2023

Approved, but looks like there's a test failure

dovholuknf
dovholuknf reviewed Oct 23, 2023
View reviewed changes
identity.go Outdated Show resolved Hide resolved
dovholuknf
dovholuknf reviewed Oct 23, 2023
View reviewed changes
identity.go Outdated Show resolved Hide resolved
dovholuknf
dovholuknf reviewed Oct 23, 2023
View reviewed changes
chains.go Show resolved Hide resolved
@andrewpmartinez
Copy link
Member Author

Approved, but looks like there's a test failure

Fixed.

@andrewpmartinez andrewpmartinez merged commit 98049f1 into main Oct 23, 2023
6 checks passed
@andrewpmartinez andrewpmartinez deleted the fix.ziti.1422.leafs.from.cas branch October 23, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dovholuknf dovholuknf dovholuknf left review comments

@plorenz plorenz plorenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewpmartinez @plorenz @dovholuknf