Inadvertantly exposed validate package. (#5726)

The validate package was not meant to be public, moving it to internal. Signed-off-by: jesus m. rodriguez <[email protected]>
operator-framework · May 4, 2022 · d43225a · d43225a
1 parent a217ff4
commit d43225a
Show file tree

Hide file tree

Showing 11 changed files with 20 additions and 2 deletions.
diff --git a/changelog/fragments/01-move-validate-to-internal.yaml b/changelog/fragments/01-move-validate-to-internal.yaml
@@ -0,0 +1,18 @@
+# entries is a list of entries to include in
+# release notes and/or the migration guide
+entries:
+  - description: >
+      The validate package was inadvertantly exposed, it should be internal as
+      all the other packages are in operator-sdk. The package was moved
+      from `pkg/validate` to `internal/validate`.
+
+    # kind is one of:
+    # - addition
+    # - change
+    # - deprecation
+    # - removal
+    # - bugfix
+    kind: "change"
+
+    # Is this a breaking change?
+    breaking: false
diff --git a/internal/cmd/operator-sdk/bundle/validate/validate.go b/internal/cmd/operator-sdk/bundle/validate/validate.go
@@ -33,7 +33,7 @@ import (
 	"k8s.io/apimachinery/pkg/labels"
 
 	internalregistry "github.com/operator-framework/operator-sdk/internal/registry"
-	"github.com/operator-framework/operator-sdk/pkg/validate"
+	"github.com/operator-framework/operator-sdk/internal/validate"
 )
 
 type bundleValidateCmd struct {

diff --git a/internal/cmd/operator-sdk/bundle/validate/validate_test.go b/internal/cmd/operator-sdk/bundle/validate/validate_test.go
@@ -20,7 +20,7 @@ import (
 	log "github.com/sirupsen/logrus"
 	"github.com/spf13/pflag"
 
-	"github.com/operator-framework/operator-sdk/pkg/validate"
+	"github.com/operator-framework/operator-sdk/internal/validate"
 )
 
 var _ = Describe("Running a bundle validate command", func() {

diff --git a/pkg/validate/external.go → internal/validate/external.go b/pkg/validate/external.go → internal/validate/external.go
diff --git a/pkg/validate/external_test.go → internal/validate/external_test.go b/pkg/validate/external_test.go → internal/validate/external_test.go
diff --git a/pkg/validate/result.go → internal/validate/result.go b/pkg/validate/result.go → internal/validate/result.go
diff --git a/pkg/validate/result_test.go → internal/validate/result_test.go b/pkg/validate/result_test.go → internal/validate/result_test.go
diff --git a/pkg/validate/suite_test.go → internal/validate/suite_test.go b/pkg/validate/suite_test.go → internal/validate/suite_test.go
diff --git a/pkg/validate/testdata/errors.sh → internal/validate/testdata/errors.sh b/pkg/validate/testdata/errors.sh → internal/validate/testdata/errors.sh
diff --git a/pkg/validate/testdata/fails.sh → internal/validate/testdata/fails.sh b/pkg/validate/testdata/fails.sh → internal/validate/testdata/fails.sh
diff --git a/pkg/validate/testdata/passes.sh → internal/validate/testdata/passes.sh b/pkg/validate/testdata/passes.sh → internal/validate/testdata/passes.sh