Skip to content

Commit

Permalink
Allow to override enableSignatureV4Streaming for s3 storage (#96)
Browse files Browse the repository at this point in the history
  • Loading branch information
crohr authored Mar 25, 2024
1 parent 55e65a9 commit 7ed385b
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 10 deletions.
6 changes: 4 additions & 2 deletions charts/openproject/templates/secret_s3.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ stringData:
OPENPROJECT_FOG_CREDENTIALS_REGION: {{ .Values.s3.region }}
OPENPROJECT_FOG_CREDENTIALS_PATH__STYLE: "{{ .Values.s3.pathStyle }}"
OPENPROJECT_FOG_CREDENTIALS_AWS__SIGNATURE__VERSION: "{{ .Values.s3.signatureVersion }}"
OPENPROJECT_FOG_CREDENTIALS_USE__IAM__PROFILE: "{{ .Values.s3.use_iam_profile }}"
OPENPROJECT_DIRECT__UPLOADS: "{{ .Values.s3.directUploads }}"
# remove use_iam_profile fallback after some point
OPENPROJECT_FOG_CREDENTIALS_USE__IAM__PROFILE: {{ .Values.s3.useIamProfile | default .Values.s3.use_iam_profile | default "false" | quote }}
OPENPROJECT_FOG_CREDENTIALS_ENABLE__SIGNATURE__V4__STREAMING: {{ .Values.s3.enableSignatureV4Streaming | default "true" | quote }}
OPENPROJECT_DIRECT__UPLOADS: {{ .Values.s3.directUploads | default "true" | quote }}
...
{{- end }}
15 changes: 7 additions & 8 deletions charts/openproject/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ global:
#
imagePullSecrets: []


## Affinity for pod assignment.
##
## Ref: https://kubernetes.io/docs/concepts/configuration/assign-pod-node/#affinity-and-anti-affinity
Expand Down Expand Up @@ -255,7 +254,6 @@ workers:
## Ref.: https://www.openproject.org/docs/installation-and-operations/configuration/environment/#supported-environment-variables
#
openproject:

## Enable https in backend response.
#
https: true
Expand Down Expand Up @@ -290,10 +288,10 @@ openproject:
# only applicable on first installation
# Note: Only applicable for versions >= 13.0
admin_user:
password: 'admin'
password_reset: 'true'
name: 'OpenProject Admin'
mail: '[email protected]'
password: "admin"
password_reset: "true"
name: "OpenProject Admin"
mail: "[email protected]"

## Define OpenID Connect providers
oidc:
Expand All @@ -312,7 +310,6 @@ openproject:
# Optional attribute mappings from the id token
attribute_map: {}


## To avoid having sensitive credentials in your values.yaml, the preferred way is to
## use an existing secret containing the OIDC compatible access credentials.
## Specify the name of this existing secret here.
Expand Down Expand Up @@ -409,7 +406,9 @@ s3:
host:
pathStyle: false
signatureVersion: 4
use_iam_profile: false
useIamProfile: false
# Some providers do not properly support signature v4 streaming (e.g. Scaleway)
enableSignatureV4Streaming: true

## If enabled, upload files directly to S3 from the browser instead of going through OpenProject.
## May not be supported by providers other than AWS S3 itself.
Expand Down

0 comments on commit 7ed385b

Please sign in to comment.