Merge pull request #16256 from opf/housekeeping/bump-primer-0-39-1

Bump primer to 0.39.1

Gemfile

@@ -392,4 +392,4 @@ end
 
 gem "openproject-octicons", "~>19.17.0"
 gem "openproject-octicons_helper", "~>19.17.0"
-gem "openproject-primer_view_components", "~>0.39.0"
+gem "openproject-primer_view_components", "~>0.39.1"

Gemfile.lock

@@ -777,7 +777,7 @@ GEM
       actionview
       openproject-octicons (= 19.17.0)
       railties
-    openproject-primer_view_components (0.39.0)
+    openproject-primer_view_components (0.39.1)
       actionview (>= 5.0.0)
       activesupport (>= 5.0.0)
       openproject-octicons (>= 19.17.0)
@@ -1267,7 +1267,7 @@ DEPENDENCIES
   openproject-octicons (~> 19.17.0)
   openproject-octicons_helper (~> 19.17.0)
   openproject-openid_connect!
-  openproject-primer_view_components (~> 0.39.0)
+  openproject-primer_view_components (~> 0.39.1)
   openproject-recaptcha!
   openproject-reporting!
   openproject-storages!

frontend/package.json

@@ -98,7 +98,7 @@
     "@ngneat/content-loader": "^7.0.0",
     "@ngx-formly/core": "^6.1.4",
     "@openproject/octicons-angular": "^19.17.0",
-    "@openproject/primer-view-components": "^0.39.0",
+    "@openproject/primer-view-components": "^0.39.1",
     "@openproject/reactivestates": "^3.0.1",
     "@primer/css": "^21.3.3",
     "@types/hotwired__turbo": "^8.0.1",
@@ -175,6 +175,6 @@
     "generate-typings": "tsc -d -p src/tsconfig.app.json"
   },
   "overrides": {
-    "@primer/view-components": "npm:@openproject/primer-view-components@^0.39.0"
+    "@primer/view-components": "npm:@openproject/primer-view-components@^0.39.1"
   }
 }

lookbook/docs/patterns/10-page-header.md.erb

@@ -39,7 +39,8 @@ There are minor adjustments on how the composition of this component is defined
 **Don't**
 
 - Don’t use the trailing action in the PageHeader as navigation element “back”, the breadcrumb and the browser back are covering this case.
-- Use PageHeaders as section sub-header inside of the content of the page.
+- Don't use create buttons as action of the PageHeader. They belong into the `Primer::OpenProject::SubHeader`, even if the SubHeader only consists of that button.
+- Don't use PageHeaders as a section header inside of the content of the page.
 
 ## Used in