-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add an enterprise banner on top of automatic subject configuration
We are making sure that users can revert back to manual subjects at any time and even keep using the feature if it's still enabled after their enterprise token expired. They will merely not be able to set new types to automatic and have to live with an enterprise banner being shown to them whenever they change the subject config.
- Loading branch information
1 parent
54bd074
commit 9a8ad7b
Showing
6 changed files
with
108 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93 changes: 93 additions & 0 deletions
93
spec/components/work_packages/types/subject_configuration_component_spec.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,93 @@ | ||
# frozen_string_literal: true | ||
|
||
# -- copyright | ||
# OpenProject is an open source project management software. | ||
# Copyright (C) 2010-2024 the OpenProject GmbH | ||
# | ||
# This program is free software; you can redistribute it and/or | ||
# modify it under the terms of the GNU General Public License version 3. | ||
# | ||
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows: | ||
# Copyright (C) 2006-2013 Jean-Philippe Lang | ||
# Copyright (C) 2010-2013 the ChiliProject Team | ||
# | ||
# This program is free software; you can redistribute it and/or | ||
# modify it under the terms of the GNU General Public License | ||
# as published by the Free Software Foundation; either version 2 | ||
# of the License, or (at your option) any later version. | ||
# | ||
# This program is distributed in the hope that it will be useful, | ||
# but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
# GNU General Public License for more details. | ||
# | ||
# You should have received a copy of the GNU General Public License | ||
# along with this program; if not, write to the Free Software | ||
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | ||
# | ||
# See COPYRIGHT and LICENSE files for more details. | ||
# ++ | ||
|
||
require "rails_helper" | ||
|
||
RSpec.describe WorkPackages::Types::SubjectConfigurationComponent, type: :component do | ||
subject(:render_component) do | ||
render_inline(described_class.new) | ||
end | ||
|
||
before do | ||
allow(EnterpriseToken).to receive(:active?).and_return(true) | ||
end | ||
|
||
it "shows no enterprise banner" do | ||
render_component | ||
|
||
expect(page).not_to have_test_selector("op-ee-banner-automatic-subject-generation") | ||
end | ||
|
||
it "enables mode selectors" do | ||
render_component | ||
|
||
page.all("input[type=radio]").each { |e| expect(e).not_to be_disabled } # rubocop:disable Rails/FindEach | ||
end | ||
|
||
context "when enterprise edition is not activated" do | ||
before do | ||
allow(EnterpriseToken).to receive(:active?).and_return(false) | ||
end | ||
|
||
it "shows the enterprise banner" do | ||
render_component | ||
|
||
expect(page).to have_test_selector("op-ee-banner-automatic-subject-generation") | ||
end | ||
|
||
it "disables mode selectors" do | ||
render_component | ||
|
||
expect(page.all("input[type=radio]")).to all(be_disabled) | ||
end | ||
|
||
context "and when the subject is already automatically generated" do | ||
before do | ||
# TODO: once has_pattern? has a non-fake implementation, this should properly set | ||
# the thing that influences has_pattern? (e.g. the backing database model) | ||
allow(WorkPackages::Types::SubjectConfigurationForm).to receive(:new).and_return( | ||
instance_double(WorkPackages::Types::SubjectConfigurationForm, has_pattern?: true).as_null_object | ||
) | ||
end | ||
|
||
it "shows the enterprise banner" do | ||
render_component | ||
|
||
expect(page).to have_test_selector("op-ee-banner-automatic-subject-generation") | ||
end | ||
|
||
it "enables mode selectors" do | ||
render_component | ||
|
||
page.all("input[type=radio]").each { |e| expect(e).not_to be_disabled } # rubocop:disable Rails/FindEach | ||
end | ||
end | ||
end | ||
end |