fix failing tests in news, activity and cost report

opf · Sep 25, 2024 · a528ecb · a528ecb
1 parent 031684c
commit a528ecb
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/app/views/activities/index.html.erb b/app/views/activities/index.html.erb
@@ -31,7 +31,7 @@ See COPYRIGHT and LICENSE files for more details.
 
 <%=
   render Primer::OpenProject::PageHeader.new do |header|
-    header.with_title { (@author.nil? ? t(:label_activity) : t(:label_user_activity, value: link_to_user(@author))) }
+    header.with_title { (@author.nil? ? t(:label_activity) : t(:label_user_activity, value: link_to_user(@author))).html_safe }
     header.with_breadcrumbs([{ href: home_path, text: organization_name},
                              *([href: project_overview_path(@project.id), text: @project.name] if @project),
                              t(:label_activity)])

diff --git a/app/views/news/index.html.erb b/app/views/news/index.html.erb
@@ -46,6 +46,7 @@ See COPYRIGHT and LICENSE files for more details.
                                    title: I18n.t(:label_work_package_status_new),
                                    tag: :a,
                                    id: 'new_news_link',
+                                   data: { "test-selector": "add-news-button"},
                                    href: new_project_news_path(@project)) do |button|
         button.with_leading_visual_icon(icon: :plus)
         t(:label_news_singular)

diff --git a/modules/reporting/spec/features/me_value_spec.rb b/modules/reporting/spec/features/me_value_spec.rb
@@ -39,7 +39,7 @@
       check "query_is_public"
       find_by_id("query-icon-save-button").click
       # wait until the save is complete
-      expect(page).to have_css("h2", text: "Query ME value")
+      expect(page).to have_css(".PageHeader-title", text: "Query ME value")
 
       expect(page).to have_css(".report", text: "10.00")
 

diff --git a/spec/features/news/creation_and_commenting_spec.rb b/spec/features/news/creation_and_commenting_spec.rb
@@ -46,9 +46,7 @@
   it "allows creating new and commenting it all of which will result in notifications and mails" do
     visit project_news_index_path(project)
 
-    within ".toolbar-items" do
-      click_link "News"
-    end
+    find('[data-test-selector="add-news-button"]', text: "News").click
 
     # Create the news
     fill_in "Title", with: "My new news"