Skip to content

Commit

Permalink
Merge pull request #13196 from opf/pin-chrome
Browse files Browse the repository at this point in the history
Pin Chromedriver to the last version that was released in the old way
  • Loading branch information
ulferts authored Jul 20, 2023
2 parents 1e55da4 + 965266a commit abad5d6
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
6 changes: 5 additions & 1 deletion config/environments/test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
# Raises error for missing translations
# config.action_view.raise_on_missing_translations = true

config.cache_store = :file_store, Rails.root.join("tmp", "cache", "paralleltests#{ENV['TEST_ENV_NUMBER']}")
config.cache_store = :file_store, Rails.root.join("tmp", "cache", "paralleltests#{ENV.fetch('TEST_ENV_NUMBER', nil)}")

if ENV['TEST_ENV_NUMBER']
assets_cache_path = Rails.root.join("tmp/cache/assets/paralleltests#{ENV['TEST_ENV_NUMBER']}")
Expand All @@ -96,4 +96,8 @@

# Speed up tests by lowering BCrypt's cost function
BCrypt::Engine.cost = BCrypt::Engine::MIN_COST

# Pin Chromedriver version to last version that was released the "old way"
# See https://github.com/titusfortner/webdrivers/issues/247
Webdrivers::Chromedriver.required_version = "114.0.5735.90"
end
2 changes: 1 addition & 1 deletion docker/ci/entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ setup_tests() {
fi

# create test database "app" and dump schema because db/structure.sql is not checked in
execute_quiet "time bundle exec rails db:migrate db:schema:dump zeitwerk:check webdrivers:chromedriver:update webdrivers:geckodriver:update"
execute_quiet "time bundle exec rails db:migrate db:schema:dump zeitwerk:check webdrivers:chromedriver:update[114.0.5735.90] webdrivers:geckodriver:update"
}

run_units() {
Expand Down
2 changes: 1 addition & 1 deletion script/ci/cache_prepare.sh
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ run() {
eval $2;
}

run "bundle exec rake db:create db:migrate webdrivers:chromedriver:update webdrivers:geckodriver:update"
run "bundle exec rake db:create db:migrate webdrivers:chromedriver:update[114.0.5735.90] webdrivers:geckodriver:update"

run "cd frontend; npm install ; cd -"

Expand Down

0 comments on commit abad5d6

Please sign in to comment.